Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB] PR #102 Rearrange Charts #282

Merged
merged 10 commits into from
Apr 4, 2024
Merged

[WEB] PR #102 Rearrange Charts #282

merged 10 commits into from
Apr 4, 2024

Conversation

jahn18
Copy link
Member

@jahn18 jahn18 commented Mar 9, 2024

Description

Verification

  • [ ]

Resources

@patrick-5546 patrick-5546 added the web Website team label Mar 9, 2024
@jahn18
Copy link
Member Author

jahn18 commented Mar 25, 2024

Thanks @fyang151!

@JordanChen123 do you mind doing a pass and taking a look at this?

@JordanChen123
Copy link
Contributor

JordanChen123 commented Mar 27, 2024

Great work! The overall code looks good to me.

There is a slight issue with the state of the graphs after refreshing the page. As an example, if you move the speed graph to the very bottom, and then refresh the page, the state of the Drag and Drop menu stays the same as it was before refreshing the page, but the graphs go back to where they were when the page was loaded up initially.

@fyang151
Copy link
Contributor

Great work! The overall code looks good to me.

There is a slight issue with the state of the graphs after refreshing the page. As an example, if you move the speed graph to the very bottom, and then refresh the page, the state of the Drag and Drop menu stays the same as it was before refreshing the page, but the graphs go back to where they were when the page was loaded up initially.

oh oops ill look at it rn and try to get it done by tn meeting

Copy link
Member Author

@jahn18 jahn18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Fred! Also, dropping some minor comments dealing with style/structure.

src/website/stores/Graphs/GraphsSagas.ts Outdated Show resolved Hide resolved
src/website/stores/Graphs/GraphsSagas.ts Outdated Show resolved Hide resolved
src/website/views/DashboardContainer.tsx Outdated Show resolved Hide resolved
src/website/views/components/DropDown/DropdownMenu.tsx Outdated Show resolved Hide resolved
src/website/views/components/DropDown/DropdownMenu.tsx Outdated Show resolved Hide resolved
src/website/views/components/DropDown/DropdownMenu.tsx Outdated Show resolved Hide resolved
@jahn18 jahn18 merged commit 929ddfe into main Apr 4, 2024
11 checks passed
@jahn18 jahn18 deleted the web-rearrange-chart branch April 4, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web Website team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to Rearrange Charts on Data Dashboard
4 participants