This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
Changed the HelperROT Type from int to float #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But should this be float or int, what do you think @hhenry01? |
Definitely int. The ais specification explicitly defines it as a signed 8 bit integer. |
|
@FireBoyAJ24 can you close this PR and make a PR in pathfinding to update the field to int? Thanks |
FireBoyAJ24
deleted the
Change-HelperROT-Type-from-int-to-float-Akshanjay
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The HelperROT type should be float rather than int as we are using the message as a float type in the local pathfinding repository.