This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
Adding More Data From AIS #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPDonaghy
requested review from
hhenry01,
patrick-5546 and
DFriend01
as code owners
|
I think @hhenry01 and @patrick-5546 are the main stakeholders here |
@DFriend01 Website depends on these interfaces as well |
Reusing HelperSpeed and HelperHeading messages instead they will be used for cog and sog added comments to describe the data in HelperAISSHIP
HelperDimensions to HelperDimension
alphabetized cmakeLists and readme
|
You can merge once your local pathfinding PR is ready to merge, as this change will break CI for everything else |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I modified HelperAISShip.msg by removing:
And adding:
I also added helper msg files for COG, SOG, Dimensions, and ROT and included them in the cmake file.
Aside from general feedback, I will need to know the units this data will come in.
Question for NET: what will be published if the requested data is not available? (ex. if the sog sensor is not working properly on some ship)
Verification
I was able to successfully create a HelperAISShip object, with the new data attributes, for use in test_obstacles.py in the local_pathfinding repository.
Resources
PR for the Issue #29 in local_pathfinding
UBCSailbot/local_pathfinding#34
I determined what data is available from AIS from this webpage
Information regarding ROT specifically, is from here