Add Multinomial Distribution and Modify Examples #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrebouchard
requested changes
Jan 11, 2019
| for (int i: 0..< numberofSuccesses.size()) { | ||
| if (probabilities.get(i) < 0.0 || probabilities.get(i) > 1.0) return NEGATIVE_INFINITY | ||
| if (numberofSuccesses.get(i) < 0.0) return NEGATIVE_INFINITY | ||
| if (numberofTrials <= 0 || numberofSuccesses.get(i) < numberofTrials) return NEGATIVE_INFINITY |
There was a problem hiding this comment.
A first problem: numberofSuccesses.get(i) < numberofTrials should be numberofSuccesses.get(i) > numberofTrials
| if (probabilities.get(i) < 0.0 || probabilities.get(i) > 1.0) return NEGATIVE_INFINITY | ||
| if (numberofSuccesses.get(i) < 0.0) return NEGATIVE_INFINITY | ||
| if (numberofTrials <= 0 || numberofSuccesses.get(i) < numberofTrials) return NEGATIVE_INFINITY | ||
| sum0 += (numberofSuccesses.get(i) * log(probabilities.get(i))) |
There was a problem hiding this comment.
Line 26 could cause 0 * -infty = NaN, which is not the right behaviour
| } | ||
| } | ||
|
|
||
| logf(numberofSuccesses, probabilities, numberofTrials) { |
There was a problem hiding this comment.
This second block should be combined with the first since it uses the same arguments.
src/test/java/blang/Examples.xtend
Outdated
| @@ -77,6 +78,18 @@ class Examples { | |||
|
|
|||
| public val List<Instance<? extends Model>> all = new ArrayList | |||
|
|
|||
| <<<<<<< HEAD | |||
| public val multinomial = add( | |||
There was a problem hiding this comment.
Add test cases with probabilities equal to zero and one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fail because of a runtime error caused by the IntSliceSampler receiving invalid parameters (0,0) in the DiscreteUnif generator. Can anyone help me with this?