Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paramiko hanging fix #180

Open
wants to merge 7 commits into
base: prefect-by-assignment
Choose a base branch
from
Open

Paramiko hanging fix #180

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bcff990
Increase window_size and max_packet_size
briank-git Oct 19, 2023
dad7631
Read stdout and stderr before getting exit status
briank-git Oct 19, 2023
452157f
Add polling on exit_status_ready before reading stdout and stderr
briank-git Oct 19, 2023
8cfccb2
Have to call exit_status_ready on a channel
briank-git Oct 19, 2023
a55cfdb
Remove re-assignment of stdout and stderr, return stdout_lines and st…
briank-git Oct 19, 2023
0fc5fd9
Revert "Have to call exit_status_ready on a channel"
briank-git Oct 19, 2023
4392320
Revert "Add polling on exit_status_ready before reading stdout and st…
briank-git Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions rudaux/snapshot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def _ssh_open(config, course_id):
client.set_missing_host_key_policy(pmk.client.AutoAddPolicy())
client.load_system_host_keys()
client.connect(stu_ssh['hostname'], stu_ssh['port'], stu_ssh['user'], allow_agent=True)
s = client.get_transport().open_session()
s = client.get_transport().open_session(window_size=1000000,max_packet_size=65536)
pmk.agent.AgentRequestHandler(s)
# TODO error handling
return client
Expand All @@ -50,22 +50,20 @@ def _ssh_command(client, cmd):
# execute the snapshot command
stdin, stdout, stderr = client.exec_command(cmd)

# block on result
out_status = stdout.channel.recv_exit_status()
err_status = stderr.channel.recv_exit_status()

logger.info(f"Command exit codes: out = {out_status} err = {err_status}")

# get output
stdout_lines = []
for line in stdout:
stdout_lines.append(line)
stdout = stdout_lines

stderr_lines = []
for line in stderr:
stderr_lines.append(line)
stderr = stderr_lines

# block on result
out_status = stdout.channel.recv_exit_status()
err_status = stderr.channel.recv_exit_status()

logger.info(f"Command exit codes: out = {out_status} err = {err_status}")

if out_status != 0 or err_status != 0:
msg = f"Paramiko SSH command error: nonzero status.\nstderr\n{stderr}\nstdout\n{stdout}"
Expand All @@ -76,7 +74,7 @@ def _ssh_command(client, cmd):
raise sig

# return
return stdout, stderr
return stdout_lines, stderr_lines

def _ssh_snapshot(config, course_id, snap_path):
logger = get_logger()
Expand Down