Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: describe enhancement or feature (Issue #41) #106

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Feat: describe enhancement or feature (Issue #41) #106

merged 6 commits into from
Oct 1, 2024

Conversation

zoidy
Copy link
Collaborator

@zoidy zoidy commented Sep 28, 2024 •
edited
Loading

Description
Add the dry run functionality by a run time flag --dry-run. Setting the flag enables dry run mode where only read operations are executed

Fixes #41

Documentation Update

  • I have updated README.md and other relevant documentation
  • No documentation update is needed

Implementation Notes
It has been tested for articles and collections and it behaves as expected

@zoidy zoidy linked an issue Sep 28, 2024 that may be closed by this pull request
Implement spec use case 3.5 (dry run mode) #41
Closed
1 task
@zoidy zoidy requested a review from HafeezOJ September 28, 2024 16:19
HafeezOJ
HafeezOJ approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@HafeezOJ HafeezOJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the codes and it worked and merged well with the existing code and the bag confirmation feature. We can merge it.

@zoidy zoidy merged commit 9e5ddaa into main Oct 1, 2024
1 check passed
@zoidy zoidy deleted the 41-implement-spec-use-case-35-dry-run-mode branch October 1, 2024 19:20
HafeezOJ pushed a commit that referenced this pull request Oct 3, 2024
@zoidy @HafeezOJ
Feat: describe enhancement or feature (Issue #41) (#106)
df8c07c 
* Add dry run argument

* add dry run arg to config object

* Add dry run functionality

* lint

* lint

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HafeezOJ HafeezOJ HafeezOJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement spec use case 3.5 (dry run mode)
2 participants
@zoidy @HafeezOJ