Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify audio stream languages #847

Merged
merged 7 commits into from
Dec 2, 2024
Merged

Identify audio stream languages #847

merged 7 commits into from
Dec 2, 2024

Conversation

Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Dec 2, 2024

Closes #845

@Tyrrrz Tyrrrz requested a review from Copilot December 2, 2024 14:32

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 12 changed files in this pull request and generated no suggestions.

Files not reviewed (7)
  • YoutubeExplode.Tests/StreamSpecs.cs: Evaluated as low risk
  • YoutubeExplode.Tests/TestData/VideoIds.cs: Evaluated as low risk
  • YoutubeExplode/Bridge/IStreamData.cs: Evaluated as low risk
  • YoutubeExplode/Videos/Streams/MuxedStreamInfo.cs: Evaluated as low risk
  • YoutubeExplode/Videos/Streams/StreamClient.cs: Evaluated as low risk
  • YoutubeExplode/Common/Language.cs: Evaluated as low risk
  • YoutubeExplode/Bridge/DashManifest.cs: Evaluated as low risk
Comments skipped due to low confidence (2)

YoutubeExplode/Utils/Extensions/JsonExtensions.cs:28

  • [nitpick] The method name 'GetBooleanOrNull' could be more descriptive. Consider renaming it to 'TryGetBoolean' to align with common naming conventions.
public static bool? GetBooleanOrNull(this JsonElement element) =>

YoutubeExplode/Bridge/PlayerResponse.cs:255

  • Ensure that the SubstringUntil method handles cases where the delimiter is not found to avoid potential unintended behavior.
?.SubstringUntil(".");
@Tyrrrz Tyrrrz merged commit 5062dc3 into master Dec 2, 2024
7 checks passed
@Tyrrrz Tyrrrz deleted the audio-lang branch December 2, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identify audio stream languages
1 participant