Add ViewCount to VideoSearchResult
#832
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. The view count is probably fine to add since it should be pretty accurate, but I'm still not in the mood to add a vague "2 years ago" date field 😁 |
Tyrrrz
changed the title
ViewCount and SimpleUploadDate to VideoSearchResult
|
Ok, I'll remove |
|
Jobs done. |
Tyrrrz
changed the title
ViewCount and SimpleUploadDate to VideoSearchResultViewCount to VideoSearchResult
How it sounded in my head:
😁 Thank you, I will take a look a bit later |
|
Ugh, I just realized that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
I know that in issue #515 you mentioned not wanting non-deterministic properties in the library, but I thought maybe today you'd be in a better mood and might press that merge button! If still no, feel free to close this.
Also, just to mention, the ViewCount property isn't non-deterministic - we can extract the exact number of views, well kind of exact, propably due to how youtube cache it. See image below.
I couldn't sleep if I didn't at least try because these properties would be really useful to me. 👉🏻👈🏻
Hope you'll consider it!
Fuck russia.