Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out streams with mismatched content length #760

Merged
merged 7 commits into from
Jan 2, 2024

Conversation

Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Jan 2, 2024

Closes #759

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (49ce828) 76.15% compared to head (174bad0) 76.48%.

Files Patch % Lines
YoutubeExplode/Videos/Streams/StreamClient.cs 78.84% 8 Missing and 3 partials ⚠️
YoutubeExplode/Videos/Streams/MediaStream.cs 75.00% 1 Missing ⚠️
YoutubeExplode/YoutubeHttpHandler.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
+ Coverage   76.15%   76.48%   +0.32%     
==========================================
  Files          99       99              
  Lines        3259     3266       +7     
  Branches      479      478       -1     
==========================================
+ Hits         2482     2498      +16     
+ Misses        553      546       -7     
+ Partials      224      222       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tyrrrz Tyrrrz merged commit dfac554 into master Jan 2, 2024
5 checks passed
@Tyrrrz Tyrrrz deleted the fix-mismatch-content-length branch January 2, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some streams can return 404
1 participant