Don't fail if can't extract three-letter language code on subs

Tyrrrz · Nov 23, 2023 · 85bbb40 · 85bbb40
1 parent 6e3e09b
commit 85bbb40
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/YoutubeExplode.Converter/Converter.cs b/YoutubeExplode.Converter/Converter.cs
@@ -135,7 +135,7 @@ private async ValueTask ProcessAsync(
         {
             arguments
                 .Add($"-metadata:s:s:{i}")
-                .Add($"language={subtitleInput.Info.Language.GetThreeLetterCode()}")
+                .Add($"language={subtitleInput.Info.Language.TryGetThreeLetterCode() ?? subtitleInput.Info.Language.GetTwoLetterCode()}")
                 .Add($"-metadata:s:s:{i}")
                 .Add($"title={subtitleInput.Info.Language.Name}");
         }

diff --git a/YoutubeExplode.Converter/Utils/Extensions/LanguageExtensions.cs b/YoutubeExplode.Converter/Utils/Extensions/LanguageExtensions.cs
@@ -1,5 +1,4 @@
-using System;
-using YoutubeExplode.Videos.ClosedCaptions;
+using YoutubeExplode.Videos.ClosedCaptions;
 
 namespace YoutubeExplode.Converter.Utils.Extensions;
 
@@ -11,7 +10,7 @@ public static string GetTwoLetterCode(this Language language)
         return dashIndex >= 0 ? language.Code[..dashIndex] : language.Code;
     }
 
-    public static string GetThreeLetterCode(this Language language) =>
+    public static string? TryGetThreeLetterCode(this Language language) =>
         language.GetTwoLetterCode().ToLowerInvariant() switch
         {
             "aa" => "aar",
@@ -204,6 +203,6 @@ public static string GetThreeLetterCode(this Language language) =>
             "za" => "zha",
             "zh" => "zho",
             "zu" => "zul",
-            var code => throw new InvalidOperationException($"Unrecognized language code '{code}'.")
+            _ => null
         };
 }