Port from WPF to Avalonia #361

Mrxx99 · 2023-08-13T21:33:40Z

Related discussion: #295

This almost finished work-in-progress of the promised Avalonia port.
Only some small differences in UI, and the web authentication is not working yet (WebView.Avalonia does not give cookie access, I have to look for alternatives), and the ffmpeg downloading has to be refactored for cross platform.

Normally Avalonia uses the .axaml file extension by default, but to have a better diff view in git I kept the .xaml file extension for now, it only needs a small addition in the project file to be supported

…y UserControl

Tyrrrz

Going great so far :) I left some comments

Tyrrrz · 2023-08-14T13:58:28Z

YoutubeDownloader/App.xaml.cs

@@ -21,37 +33,103 @@ public partial class App
    public static string ChangelogUrl { get; } = ProjectUrl + "/blob/master/Changelog.md";
 }

-public partial class App
+[DoNotNotify]
+public partial class App : StyletApplication<RootViewModel>


Is there a specific reason you merged the bootstrapper with the App?

because it seems like these were merged in Stylet.Avalonia https://github-com.translate.goog/sealoyal2018/Stylet.Avalonia?_x_tr_sl=auto&_x_tr_tl=de&_x_tr_hl=de

Do you think we need Stylet at all? I remember we discussed this and you said Avalonia already provides many of its features out of the box (such as method binding). Does Avalonia have something for binding views to view models automatically too?

I had started first without Stylet because it was still lacking behind in Avalonia previews when Avalonia 11 was still in preview. But since somethings changed with Avalonia till the release and also YoutubeDownloader moved forward I somewhat started again to not miss any of the changes. When I started again I used Stylet.Avalonia because it was faster. But I can again migrate of it. A drawback of the Stylet.Avalonia (which is a independet fork of Stylet) is also that is completey switched its readme to Chinese only.

Yes Avalonia has some parts already build in like binding to methods form commands (not from events) and one can easily build a general ViewLocator which is provided with the MVVM templates. I can change to that approach together with CommunityToolkit.MVVM from microsoft for some MVVM stuff. But I ended up rebuild some parts of Stylet, it would not be a problem for me since I had done that already.
You can also look at my first attempt here: https://github.dev/Mrxx99/YoutubeDownloader/tree/Avalonia/YoutubeDownloader.Avaloniav11

We could also wait until Caliburn.Micro is released (officially) for Avalonia which should be (hopefully) soon: Caliburn-Micro/Caliburn.Micro#851

Yes Avalonia has some parts already build in like binding to methods form commands (not from events) and one can easily build a general ViewLocator which is provided with the MVVM templates. I can change to that approach together with CommunityToolkit.MVVM from microsoft for some MVVM stuff. But I ended up rebuild some parts of Stylet, it would not be a problem for me since I had done that already.

I'm pretty ambivalent, I think. We already have some "plumbing code" in ViewModels/Framework I think, so it wouldn't be too big of a deal if we added more. I'm also not opposed to adding 3rd party packages, as long as they're fairly widely used and are trustworthy.

I'll leave the decision up to you, let's go with whatever you think provides the best balance in terms of effort/control.

one can easily build a general ViewLocator which is provided with the MVVM templates. I can change to that approach together with CommunityToolkit.MVVM

if you're thinking of using the CommunityToolkit.MVVM tools, they also built a DependencyInjection package with source generators that:

Makes the service registration completely trim/AOT-friendly

Provides built-time diagnostics on registration errors

With that, it's possible to build an improved version of the ViewLocator. Here's a demo project from @stevemonaco that uses the DI package.

The package is experimental, but apparently it is used in production and they're just waiting for the first chance to push it into the stable Nuget feed.

The package is experimental, but apparently it is used in production and they're just waiting for the first chance to push it into the stable Nuget feed.

I asked Sergio about this in the past week or so. He said that his MEDI sourcegen is currently being used in Windows Store, but he's lacking the time to move the code base/packaging into CommunityToolkit proper.

YoutubeDownloader/Controls/Hyperlink.cs

YoutubeDownloader/Program.cs

YoutubeDownloader/Utils/MediaColor.cs

YoutubeDownloader/ViewModels/Framework/DialogManager.cs

YoutubeDownloader/Views/Dialogs/DownloadSingleSetupView.xaml

YoutubeDownloader/YoutubeDownloader.csproj

YoutubeDownloader/app.manifest

Co-authored-by: Oleksii Holub <[email protected]>

…tubeDownloader into feature/avalonia-port

Mrxx99 · 2023-08-14T18:48:06Z

@Tyrrrz Do you want to add support for Android and iOS at some point too?
I guess webassembly won't work due to CORS

Tyrrrz · 2023-08-14T20:01:03Z

@Tyrrrz Do you want to add support for Android and iOS at some point too? I guess webassembly won't work due to CORS

No, I think it would be unnecessary.

Tyrrrz · 2023-08-14T20:02:28Z

Might want to merge/rebase to get the gitignore changes in

Mrxx99 · 2023-08-14T20:04:31Z

Might want to merge/rebase to get the gitignore changes in

I did already

Tyrrrz · 2023-08-14T20:06:18Z

Might want to merge/rebase to get the gitignore changes in

I did already

Nice, I see now. Had outdated diff for a sec.

YoutubeDownloader/Converters/VideoQualityPreferenceToStringConverter.cs

Tyrrrz · 2023-08-18T16:48:04Z

...and the ffmpeg downloading has to be refactored for cross platform.

I'm thinking that the best way is to download it on-demand during application run time. That way we don't have to package a million different versions of ffmpeg.

We should do it separately though, not in this PR. For now let's just keep ffmpeg Windows-only in this iteration.

Tyrrrz · 2023-08-21T21:06:23Z

Do you think we should change async void methods on the view model side to async Task? I remember having issues with this & WPF, but maybe it works seamlessly in Avalonia.

…ylet action for commands

YoutubeDownloader/Views/Dialogs/AuthSetupView.xaml

YoutubeDownloader/Views/Dialogs/AuthSetupView.xaml.cs

…olve viewmodels from DI as well

Tyrrrz · 2024-03-02T02:09:55Z

YoutubeDownloader/Views/Components/DashboardView.xaml.cs

-
-            // We handle the event here so we have to directly "press" the default button
-            AccessKeyManager.ProcessKey(null, "\x000D", false);
+            await downloadViewModel.CopyErrorMessage();


Probably can just do DataContext.CopyErrorMessage now and simplify the if

You mean because of the ViewModelAwareUserControl generics? That won't work, because the DataContext of the view is DashboardViewModel. Or do you mean just doing casting on the call site instead of type check in the if?

Tyrrrz · 2024-03-02T02:13:33Z

YoutubeDownloader/Views/Components/DashboardView.xaml.cs

 {
    public DashboardView()
    {
        InitializeComponent();
+        QueryTextBox.AddHandler(


Why is this event handled with AddHandler and the other (OnStatusPointerReleased) with XAML binding. Is one approach better than the other somehow? If they're the same, can we standardize?

AddHanlder is used here as in Avalonia there are no Preview* helper events, so with using AddHandler you can specify the routing strategy as tunnel, which is the equivalent of preview events in WPF. A "preview" event is required here, as otherwise the enter key would have already created a new line.

Tyrrrz · 2024-03-02T02:20:20Z

YoutubeDownloader/Views/Dialogs/AuthSetupView.xaml.cs

+    private void WebBrowser_OnUnloaded(object? sender, RoutedEventArgs e)
    {
        // This will most likely not work because WebView2 would still be running at this point,
        // and there doesn't seem to be any way to shut it down using the .NET API.
-        if (WebBrowser.CoreWebView2?.Profile is not null)
-            await WebBrowser.CoreWebView2.Profile.ClearBrowsingDataAsync();
+        // if (_coreWebView2?.Profile is not null)
+        //     await _coreWebView2.Profile.ClearBrowsingDataAsync();
    }


Are these methods not accessible or why are they commented out?

the webview is already disposed at that point so it throws an exception:

System.InvalidOperationException: CoreWebView2 members cannot be accessed after the WebView2 control is disposed.

So I guess the handler can just be removed.

Tyrrrz · 2024-03-02T02:48:26Z

Finally finished reviewing!

One more thing: can you please add the Async suffix to all methods that return async Task (but not async void) for consistency?

Tyrrrz · 2024-03-04T18:48:36Z

Also, feel free to rename .xaml to .axaml since Rider supports designer preview in those files with an extension too

YoutubeDownloader/YoutubeDownloader.csproj

Tyrrrz · 2024-03-07T17:47:29Z

@Mrxx99 let me know if you're too busy and would rather have this merged as is. I can then just apply my suggestions locally.

Mrxx99 · 2024-03-07T19:35:17Z

@Mrxx99 let me know if you're too busy and would rather have this merged as is. I can then just apply my suggestions locally.

I started working on the Async postfixes, which required more changes as with the renaming the auto detect CanExecute of Avalonia does not work anymore (because of different names) and there were also some issues with them anyway, do I am changing them to use the RelayCommand generator of the MVVM toolkit

Tyrrrz · 2024-03-07T19:50:56Z

@Mrxx99 let me know if you're too busy and would rather have this merged as is. I can then just apply my suggestions locally.

I started working on the Async postfixes, which required more changes as with the renaming the auto detect CanExecute of Avalonia does not work anymore (because of different names) and there were also some issues with them anyway, do I am changing them to use the RelayCommand generator of the MVVM toolkit

Okay, no worries. If those changes end up being more complicated than expected, let me know and we can descope them.

Mrxx99 · 2024-03-11T21:21:55Z

Also, feel free to rename .xaml to .axaml since Rider supports designer preview in those files with an extension too

Yes, I know, I just had them as xaml to have better diff at the PR. So I think it would make sense to change the extension after merging the PR so the changes could still be seen at the PR.

Tyrrrz · 2024-03-12T13:44:31Z

Also, feel free to rename .xaml to .axaml since Rider supports designer preview in those files with an extension too

Yes, I know, I just had them as xaml to have better diff at the PR. So I think it would make sense to change the extension after merging the PR so the changes could still be seen at the PR.

Yes, very good point.

Mrxx99 · 2024-03-23T20:22:50Z

Hi @Tyrrrz I think this can be merged, you can maybe look at the unresolved comments.
Regarding the updating problem I mentioned, I think this was happening because I still had the IDE open and it maybe was locking the files as it seems to work fine when I start the exe with no IDE open. (But one thing I noticed, as it updated to the original one, the Avalonia files were not removed, is this a bug in Onova, that it does not cleanup old files?)

Mrxx99 · 2024-03-23T20:45:27Z

One thing I noticed, the build output contains the runtimes folder, with native binaries for linux, mac and windows. For windows users that would be at least 50 MB additional. You can publish with --runtime to only get the binaries for windows, but then it would need three different publishes (and three resulting binaries) for win-x64, win-86 and win-arm64.
Or after a publish the non-windows runtime folders could be deleted for the windows build

Tyrrrz · 2024-03-24T19:03:34Z

Thank you @Mrxx99. I'm currently in the process of converting LightBulb to Avalonia, as I wanted to gain some personal experience with the framework. I will get back to this PR once I'm finished there.

Tyrrrz · 2024-04-03T01:16:39Z

Thanks again for the massive effort @Mrxx99! I'll take it from here now.

Mrxx99 added 7 commits August 13, 2023 23:06

WIP: avalonia port

370ad0d

added UserControlBase to not have to add DoNotNotifyAttribute to ever…

87f503b

…y UserControl

small fix

66e3b57

Merge from develop

6a782ae

removed WPF Stylet reference

e6f8190

display window icon

6b27939

fixed query textbox background

59e31bb

Tyrrrz added the enhancement New feature or request label Aug 14, 2023

Tyrrrz reviewed Aug 14, 2023

View reviewed changes

Tyrrrz changed the title ~~WIP: Avalonia port~~ Port from WPF to Avalonia Aug 14, 2023

Mrxx99 and others added 5 commits August 14, 2023 20:11

Update YoutubeDownloader/YoutubeDownloader.csproj

df71416

Co-authored-by: Oleksii Holub <[email protected]>

implemented some feedback

b132dfa

removed vs files

71df82d

Merge branch 'feature/avalonia-port' of https://github.com/Mrxx99/You…

b1c931f

…tubeDownloader into feature/avalonia-port

Merge branch 'master' into feature/avalonia-port

b6dfe67

Tyrrrz reviewed Aug 14, 2023

View reviewed changes

YoutubeDownloader/Converters/VideoQualityPreferenceToStringConverter.cs Outdated Show resolved Hide resolved

Mrxx99 added 3 commits August 19, 2023 17:11

updated to avalonina 11.0.4

8ec0ba2

removed MessageBox.Avalonia package since it's not used

ad75a3c

updated Material.Avalonia to latest nightly

ca8728b

use async Task instead of async void and normal binding instead of st…

c4a4f51

…ylet action for commands

Tyrrrz mentioned this pull request Aug 23, 2023

Linux support #180

Closed

Mrxx99 and others added 2 commits September 4, 2023 21:49

try webview with CefGlue

90ed00b

Merge branch 'master' into feature/avalonia-port

7070c55

renamed SnackbarService.PostDefault to Post

f24c85e

Tyrrrz reviewed Mar 1, 2024

View reviewed changes

YoutubeDownloader/Views/Dialogs/AuthSetupView.xaml Outdated Show resolved Hide resolved

Tyrrrz reviewed Mar 1, 2024

View reviewed changes

YoutubeDownloader/Views/Dialogs/AuthSetupView.xaml.cs Outdated Show resolved Hide resolved

Tyrrrz reviewed Mar 1, 2024

View reviewed changes

YoutubeDownloader/Views/Dialogs/AuthSetupView.xaml.cs Outdated Show resolved Hide resolved

Mrxx99 added 4 commits March 1, 2024 22:45

use MVVM toolkit commands for binding to methods

47c471a

using AcitvatorUtilities.GetServiceOrCreateInstance to be able to res…

69f5ffe

…olve viewmodels from DI as well

make ViewModelAwareUserControl generic, introduce ViewModel property

4afc9e9

removed not needed WebBrowser_OnNavigationCompleted event handler

880504e

Tyrrrz reviewed Mar 2, 2024

View reviewed changes

Tyrrrz approved these changes Mar 2, 2024

View reviewed changes

simplify logout button

a100302

Tyrrrz reviewed Mar 4, 2024

View reviewed changes

YoutubeDownloader/YoutubeDownloader.csproj Show resolved Hide resolved

remove unused WebView event handler

d66dd9e

add Async PostFix and fix commands

fd72e7b

set application icon

e1d4189

Tyrrrz merged commit c09bc00 into Tyrrrz:master Apr 3, 2024
4 checks passed

Tyrrrz mentioned this pull request Apr 28, 2024

Make the app x-platform #436

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port from WPF to Avalonia #361

Port from WPF to Avalonia #361

Mrxx99 commented Aug 13, 2023

Tyrrrz left a comment

Tyrrrz Aug 14, 2023

Mrxx99 Aug 14, 2023

Tyrrrz Aug 14, 2023

Mrxx99 Aug 14, 2023

Tyrrrz Aug 14, 2023

MammaMiaDev Dec 14, 2023

stevemonaco Dec 14, 2023

Mrxx99 commented Aug 14, 2023 •

edited

Loading

Tyrrrz commented Aug 14, 2023

Tyrrrz commented Aug 14, 2023

Mrxx99 commented Aug 14, 2023

Tyrrrz commented Aug 14, 2023

Tyrrrz commented Aug 18, 2023

Tyrrrz commented Aug 21, 2023

Tyrrrz Mar 2, 2024

Mrxx99 Mar 2, 2024

Tyrrrz Mar 2, 2024

Mrxx99 Mar 2, 2024

Tyrrrz Mar 2, 2024

Mrxx99 Mar 2, 2024

Tyrrrz commented Mar 2, 2024

Tyrrrz commented Mar 4, 2024

Tyrrrz commented Mar 7, 2024

Mrxx99 commented Mar 7, 2024

Tyrrrz commented Mar 7, 2024

Mrxx99 commented Mar 11, 2024

Tyrrrz commented Mar 12, 2024

Mrxx99 commented Mar 23, 2024

Mrxx99 commented Mar 23, 2024

Tyrrrz commented Mar 24, 2024

Tyrrrz commented Apr 3, 2024

Port from WPF to Avalonia #361

Port from WPF to Avalonia #361

Conversation

Mrxx99 commented Aug 13, 2023

Tyrrrz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mrxx99 commented Aug 14, 2023 • edited Loading

Tyrrrz commented Aug 14, 2023

Tyrrrz commented Aug 14, 2023

Mrxx99 commented Aug 14, 2023

Tyrrrz commented Aug 14, 2023

Tyrrrz commented Aug 18, 2023

Tyrrrz commented Aug 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tyrrrz commented Mar 2, 2024

Tyrrrz commented Mar 4, 2024

Tyrrrz commented Mar 7, 2024

Mrxx99 commented Mar 7, 2024

Tyrrrz commented Mar 7, 2024

Mrxx99 commented Mar 11, 2024

Tyrrrz commented Mar 12, 2024

Mrxx99 commented Mar 23, 2024

Mrxx99 commented Mar 23, 2024

Tyrrrz commented Mar 24, 2024

Tyrrrz commented Apr 3, 2024

Mrxx99 commented Aug 14, 2023 •

edited

Loading