Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release Continues Delivery #145

Closed
wants to merge 3 commits into from

Conversation

dotnetCarpenter
Copy link
Contributor

  • update checkout action
  • use checkout cache instead of cache action
  • get rid of npm usage

@dotnetCarpenter dotnetCarpenter marked this pull request as ready for review November 8, 2024 21:21
@dotnetCarpenter
Copy link
Contributor Author

I don't understand the failure point: - Resolving version...

Run GabrielBB/xvfb-action@v1
  with:
    run: yarn test
/Users/runner/.yarn/bin/yarn test
yarn run v1.22.22
warning [email protected]: The engine "vscode" appears to be invalid.
$ yarn compile
warning [email protected]: The engine "vscode" appears to be invalid.
$ tsc -p ./
$ node ./out/test/runTest.js
- Resolving version...
Failed to run tests
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: The process '/Users/runner/.yarn/bin/yarn' failed with exit code 1

@dotnetCarpenter
Copy link
Contributor Author

I'm marking this as draft until #146 is merged. It seems that GabrielBB/xvfb-action@v1 is flaky on macos.
This PR passes all checks after #146. See https://github.com/dotnetCarpenter/vscode-sort-lines/actions/runs/11749950666

@dotnetCarpenter dotnetCarpenter marked this pull request as draft November 8, 2024 21:46
@Tyriar
Copy link
Owner

Tyriar commented Nov 9, 2024

get rid of npm usage

Another clean up I'd like to do FYI is to remove yarn to simplify things even more. VS Code's codebase moves away from this some time ago and that's the main reason some of my projects were on it to keep things consistent.

@dotnetCarpenter
Copy link
Contributor Author

get rid of npm usage

Another clean up I'd like to do FYI is to remove yarn to simplify things even more.

So move to npm?

@dotnetCarpenter dotnetCarpenter marked this pull request as ready for review November 10, 2024 18:47
@dotnetCarpenter
Copy link
Contributor Author

Ready for review @Tyriar

@dotnetCarpenter
Copy link
Contributor Author

Surpassed by #147

@dotnetCarpenter dotnetCarpenter deleted the fixing-release branch November 20, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants