refactor(*): configured eslint #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 34 34
Lines 658 658
Branches 82 82
=======================================
Hits 615 615
Misses 30 30
Partials 13 13
Continue to review full report at Codecov.
|
LironHazan
commented
Oct 9, 2021
| @@ -0,0 +1,173 @@ | |||
| { | |||
| "env": { | |||
| "browser": true, | |||
There was a problem hiding this comment.
can toggle to false..
LironHazan
commented
Oct 9, 2021
| @@ -1,4 +1,5 @@ | |||
| import {MethodToStub} from "./MethodToStub"; | |||
| import {Mocker} from "./Mock"; | |||
LironHazan
commented
Oct 9, 2021
| @@ -91,14 +91,14 @@ describe("resetting mocked object", () => { | |||
| // given | |||
| foo.getBar(); | |||
| foo.sumTwoNumbers(2, 3); | |||
| verify(mockedFoo.getBar()).calledBefore(mockedFoo.sumTwoNumbers(2, 3)); | |||
| verify(mockedFoo.getBar()).calledBefore(mockedFoo.sumTwoNumbers(2, 3) as any); | |||
There was a problem hiding this comment.
I need to go deeper on that.. cal before should expect a MethodToStub not any but mockedFoo.sumTwoNumbers(2, 3) doesn't return MethodToStub so I had to cast..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.