Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altered handleFileEvent to be able to accept extensions other than .ts and .html #404

Merged
merged 3 commits into from
May 29, 2017

Conversation

LibanHassan
Copy link
Contributor

Added support for .jsx, .tsx, and .js file extensions in the handleFileEvent function.
Tests remained the same after changes in addition to not introducing any breaking changes.
This PR fixes issue #363.

Altered handleFileEvent to be able to accept extensions other than .ts and .html
@LibanHassan
Copy link
Contributor Author

It appears that the transform tests were failing before my changes and that is why the Travis CI build failed.

@nycdotnet
Copy link
Contributor

Thanks for submitting. I'll take a look soon.

@nycdotnet nycdotnet merged commit 95be19f into TypeStrong:master May 29, 2017
@nycdotnet
Copy link
Contributor

Thank you very much!

@nycdotnet
Copy link
Contributor

This is released in grunt-ts v6.0.0-beta.16 on npm. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants