fix: Multi-editor drag & drop #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… thrown after drag & drop
YousefED
reviewed
Jan 10, 2025
packages/core/src/blocks/HeadingBlockContent/HeadingBlockContent.ts
Outdated
Show resolved
Hide resolved
YousefED
reviewed
Jan 14, 2025
.../core/src/blocks/ListItemBlockContent/CheckListItemBlockContent/CheckListItemBlockContent.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes dragging & dropping blocks between different editors, and the
sideMenuDetectionoption has been added.sideMenuDetectioncan be set to"viewport"or"editor"("viewport"by default), and sets the detection area for showing the side menu.Setting it to
"viewport"makes the side menu appear whenever the cursor is beside a block, anywhere on the page. Setting it to"editor"makes the side menu only appear when the cursor is over the editor, or slightly to the left to account for the side menu area.The same goes for dragging and dropping blocks, where
"viewport"will clamp the mouse x-coordinate to the side of the editor.Closes #657
Closes #1194
Closes #1246