[TT-13440] fix: correctly sync multi-value response headers with coprocess middl… #6394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
as this is my first PR to your project please let me know what further information you need for a review.
Description
When synchronizing single- and multi-valued header representations (of coprocess-based middleware responses) the list of values for any multi-valued header is currently replaced by a list containing only the value given by its single-value representation effectively dropping all but the first value. Instead synchronization should affect/replace only the first value and retain possibly remaining values.
Related Issue
fixes #6411
Motivation and Context
We like to employ Tyk Gateway with a coprocess-based response middleware attached to an upstream possibly responding with multiple Set-Cookie headers. We also require our middleware to modify other headers like Location. As is due to synchronization only the first Set-Cookie header passes our middleware.
How This Has Been Tested
This PR adds a test which should fail without proposed fix.
Types of changes
Checklist