-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-9985] add proxy protocol for http #5464
Open
ldmonster
wants to merge
47
commits into
TykTechnologies:master
Choose a base branch
from
ldmonster:feature/add-proxy-protocol
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[TT-9985] add proxy protocol for http #5464
ldmonster
wants to merge
47
commits into
TykTechnologies:master
from
ldmonster:feature/add-proxy-protocol
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lghiur
changed the title
add proxy protocol for http
[TT-9985] add proxy protocol for http
Sep 6, 2023
titpetric
reviewed
Jun 27, 2024
titpetric
reviewed
Jun 27, 2024
titpetric
reviewed
Jun 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ha proxy protocol handling added
Description
Usually, flow looks like proxyproto.Listener -> tls.Listener -> net.Listener. Because of it - we have an early tls handshake and fail. Now, we have a middle wrap, like tls.Listener -> proxyproto.Listener -> net.Listener , and it works smooth.
When i trying to upgrade listener in generateListener func - it throws error like "port is already in use". Because of it - listener upgrading now before HTTP server start.
Related Issue
#5463
Motivation and Context
With this feature we can use ha-proxy-protocol in our projects, with easy toggle from config file.
How This Has Been Tested
Tested in our infrastructure using ha-proxy to wrap request with tls, and sending to tyk.
Result: we have a new header "x-forwarded-for" with correct IP on the board.
Screenshots (if appropriate)
Types of changes
Checklist