-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-14170] Update documentation for master Gateway #6061
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 similar comment
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested improvements and comments.
Default: | ||
name: Default | ||
oasApiDefinition: | ||
summary: Calling debug endpoint with OAS API definition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be Tyk OAS API definition. It is potentially confusing to say "OAS API definition".
name: Default | ||
examples: | ||
apiDefinition: | ||
summary: Calling debug endpoint with classic API definition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be Tyk Classic API definition
@@ -1861,7 +1903,7 @@ paths: | |||
schema: | |||
$ref: '#/components/schemas/ApiStatusMessage' | |||
description: Internal server error. | |||
summary: Test an an API definition. | |||
summary: Test a Classic or an OAS API definition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
summary: Test a Classic or an OAS API definition. | |
summary: Test a Tyk Classic or Tyk OAS API definition. |
@@ -2094,7 +2138,7 @@ Sample Override Message Setting | |||
ENV: <b>TYK_GW_CLOUD</b><br /> | |||
Type: `bool`<br /> | |||
|
|||
Cloud flag shows the Gateway runs in migration-to-tyk#begin-with-tyk-cloud. | |||
Cloud flag shows the Gateway runs in Tyk-cloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cloud flag shows the Gateway runs in Tyk-cloud. | |
Cloud flag indicates that the Gateway is deployed in a Tyk Cloud data plane. |
@@ -26,7 +26,7 @@ Custom hostname for the Control API | |||
ENV: <b>TYK_GW_CONTROLAPIPORT</b><br /> | |||
Type: `int`<br /> | |||
|
|||
Set to run your Gateway Control API on a separate port, and protect it behind a firewall if needed. Please make sure you follow this guide when setting the control port https://tyk.io/docs/tyk-self-managed/#change-your-control-port. | |||
Set to run your Gateway Control API on a separate port, and protect it behind a firewall if needed. Please make sure you follow this guide when setting the control port https://tyk.io/docs/planning-for-production/#change-your-control-port. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set to run your Gateway Control API on a separate port, and protect it behind a firewall if needed. Please make sure you follow this guide when setting the control port https://tyk.io/docs/planning-for-production/#change-your-control-port. | |
Set this to expose the Tyk Gateway API on a separate port. You can protect it behind a firewall if needed. Please make sure you follow this guide when setting the control port https://tyk.io/docs/planning-for-production/#change-your-control-port. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most objects are lacking their Tyk Classic equivalents - we should have these for 5.8. Note that there are a lot not included in this PR that are also missing. :(
PreserveHostHeader contains the configuration for preserving the host header. | ||
|
||
**Field: `preserveTrailingSlash` ([PreserveTrailingSlash](#preservetrailingslash))** | ||
PreserveTrailingSlash contains the configuration for preserving the host header. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct - seems to be a copy/paste error
**Field: `requestSigning` ([UpstreamRequestSigning](#upstreamrequestsigning))** | ||
RequestSigning holds the configuration for generating signed requests to an upstream API. | ||
|
||
### **LoadBalancing** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is missing the Tyk Classic equivalents
PreserveHostHeader holds the configuration for preserving the host header. | ||
|
||
**Field: `enabled` (`boolean`)** | ||
Enabled activates preserving the host header. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing the Tyk Classic equivalent
be a different endpoint from /users (for example). | ||
|
||
**Field: `enabled` (`boolean`)** | ||
Enabled activates preserving the trailing slash when routing requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing the Tyk Classic equivalent
Tyk classic API definition: `proxy.transport.ssl_min_version`. | ||
|
||
**Field: `maxVersion` (`string`)** | ||
MaxVersion is the maximum SSL/TLS version that is acceptable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing the Tyk Classic equivalent
IgnoreCase will make route matching be case insensitive. | ||
This accepts request to `/AAA` or `/aaa` if set to true. | ||
|
||
**Field: `enabled` (`boolean`)** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field is missing its Tyk Classic equivalent
**Field: `enabled` (`boolean`)** | ||
Enabled activates case insensitive route matching. | ||
|
||
### **UptimeTestCommand** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These fields are missing Tyk Classic equivalents
@@ -1122,6 +1472,9 @@ Path is the path to shared object file in case of goplugin mode or path to JS co | |||
**Field: `rawBodyOnly` (`boolean`)** | |||
RawBodyOnly if set to true, do not fill body in request or response object. | |||
|
|||
**Field: `requireSession` (`boolean`)** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This, and adjoining objects, are missing Tyk Classic equivalents
@@ -1163,6 +1516,23 @@ BodyTemplate is the template to be used for request payload. | |||
**Field: `headers` ([Headers](#headers))** | |||
Headers are the list of request headers to be used. | |||
|
|||
### **JSVMEvent** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Tyk Classic equivalents
@@ -1319,6 +1695,26 @@ Name is the name of the header. | |||
**Field: `value` (`string`)** | |||
Value is the value of the header. | |||
|
|||
### **CustomPlugin** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Tyk Classic equivalents
@@ -26,7 +26,7 @@ Custom hostname for the Control API | |||
ENV: <b>TYK_GW_CONTROLAPIPORT</b><br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing this in favor of #6083 |
User description
Triggered by: lghiur
Included:
Tyk Gateway: true
Tyk Dashboard: false
Tyk MDCB false
Tyk Pump false
Intended for: master
Changes sourced from: release-5.8.0
Config info generator branch: main
Note: Docs updates for 5.8.0 Gateway (branch suffix: docs)
JIRA: https://tyktech.atlassian.net/browse/TT-14170
PR Type
Description
Update Swagger example formats and tag naming.
Allow empty strings in enum fields for TraceRequest.
Revise configuration documentation links and descriptions.
Expand vendor extension reference with new configuration fields.
Changes walkthrough 📝
gateway-swagger.yml
Revise Swagger definitions and examples
tyk-docs/assets/others/gateway-swagger.yml
CertsTag
toCerts
.oas
property.gateway-config.md
Update Gateway configuration documentation links
tyk-docs/content/shared/gateway-config.md
access_logs
configuration section.x-tyk-gateway.md
Expand vendor extension documentation
tyk-docs/content/shared/x-tyk-gateway.md
test
touptimeTests
for API tests.