Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-9571] enterprise-portal: assign /tmp/tyk-portal to TMPDIR environment variable #145

Conversation

edsonmichaque
Copy link

@edsonmichaque edsonmichaque commented Oct 28, 2023

Description

To upload files using multi-part form in enterprise-portal we need to have write permission to /tmp, but the filesystem is mounted read-only.

We found that there is a volume mounted RW in /tmp/tyk-portal, this PR defines the environment variable TMPDIR to point to this directory. This way, whenever the portal needs to write a temporary file, it will use the directory pointed by the variable.

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@edsonmichaque edsonmichaque requested a review from a team as a code owner October 28, 2023 23:33
@edsonmichaque edsonmichaque requested review from buraksekili and removed request for a team October 28, 2023 23:33
@edsonmichaque edsonmichaque changed the title [TT-9571] Assign /tmp/tyk-portal to TMPDIR environment variable [TT-9571] enterprose-portal: assign /tmp/tyk-portal to TMPDIR environment variable Oct 28, 2023
@edsonmichaque edsonmichaque changed the title [TT-9571] enterprose-portal: assign /tmp/tyk-portal to TMPDIR environment variable [TT-9571] enterprise-portal: assign /tmp/tyk-portal to TMPDIR environment variable Oct 28, 2023
@edsonmichaque edsonmichaque self-assigned this Oct 28, 2023
@padiazg
Copy link

padiazg commented Oct 30, 2023

I think we can take another approach to fix this issue, and try to make the Portal really stateless

@edsonmichaque
Copy link
Author

Thanks @padiazg, let me close it then

@buraksekili buraksekili deleted the TT-9571-tyk-enterprise-dev-portal-on-k-8-s-not-able-to-upload-new-theme-zip-file-zipped-using-compress-in-mac branch October 30, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants