Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-10136 fix: Use the resources specified in values.yaml #121

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

jakub-bochenski
Copy link
Contributor

Fixes #120

Description

Use the actual property specified in values.yaml

Related Issue

#120

Motivation and Context

#120

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jakub-bochenski jakub-bochenski requested a review from a team as a code owner September 22, 2023 13:20
@jakub-bochenski jakub-bochenski requested review from buraksekili and removed request for a team September 22, 2023 13:20
Copy link
Collaborator

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏 LGTM

@caroltyk caroltyk changed the title fix: Use the resources specified in values.yaml TT-10136 fix: Use the resources specified in values.yaml Oct 3, 2023
@jakub-bochenski
Copy link
Contributor Author

I don't think the test failures are related to this change. Can this be merged?

@singhpr singhpr merged commit d8e3a77 into TykTechnologies:main Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set resources in pump chart
3 participants