-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TT-7219 implement HPA resource for tyk-gateway #116
TT-7219 implement HPA resource for tyk-gateway #116
Conversation
Thank you for raising the PR @rakkhin . We'll have an engineer from the team to review this. |
@rakkhin Can you add |
1f31f31
to
f203c90
Compare
@komalsukhani I've updated those charts, let me know if there's anything else left. |
@rakkhin Looks perfect. Thank you! |
@rakkhin thanks for your valuable contribution. We greatly appreciate your effort. However, it appears that there is a minor conflict in one of the files. Could you please take a moment to resolve it? If you are currently unavailable to address this matter, kindly inform us, and we will be happy to assist in resolving the conflict. |
f203c90
to
f5edeef
Compare
@buraksekili I resolved the conflict, should be good to go now. |
thank you for this great contribution @rakkhin 🙏 |
Description
This PR implements
Horizontal Pod Autoscaler
resource fortyk-gateway
chart, allowing users to easily enable automatic scaling and preventing situations described in #115.Related Issue
#115
Motivation and Context
Currently
tyk-gateway
chart doesn't have any configuration regarding automatic scaling of deployments. While it could probably be fine in dev/test environments or environments will low traffic volume variance, it's generally better to have the ability to scale your env to meet current demands. Without built-in support for HPA users are forced to manually create those resources and in some cases running the risk of destabilizing their environments, described in #115.Test Coverage For This Change
Screenshots (if appropriate)
Types of changes
Checklist
master
!master
branch (left side). Also, it would be best if you started your change off our latestmaster
.