TT-13533 int64

[tbuchaillot]

PR Type

Bug fix, Enhancement

---

Description

• Fix parsing of large integer values from string

• Add support for parsing floating point numbers and converting to int64

• Improve error handling and panic with informative message on parsing failure

---

Changes walkthrough 📝

	Relevant files
Enhancement	meta.go Add float parsing and improve error handling in ToInt        utils/meta.go Add support for parsing floating point numbers in ToInt function Convert parsed float to int64 before returning Improve error handling to panic with informative message on parsing failure +2/-0

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Potential precision loss Converting from float64 to int64 may lead to loss of precision for large floating point numbers. This should be validated to ensure it matches the expected behavior and doesn't introduce bugs for certain input values. } else if f, err := strconv.ParseFloat(result, 64); err == nil { return int64(f)

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Handle the error returned by strconv.ParseFloat in the ToInt function The ToInt function should handle the error returned by strconv.ParseFloat instead of ignoring it. If the float parsing fails, the function will incorrectly panic with a message about failing to parse an int, even though the failure was in parsing a float. utils/meta.go [76-77] } else if f, err := strconv.ParseFloat(result, 64); err == nil { return int64(f) +} else { + panic("failed to parse float: " + result) Suggestion importance[1-10]: 8 Why: The suggestion correctly identifies a bug where the error from parsing a float is ignored, leading to a misleading panic message. Fixing this is important for proper error handling and debugging.	8
General	Add a comment explaining the fallback to parsing as a float Consider adding a comment to explain why parsing as a float is attempted if parsing as an int fails. This fallback behavior may not be obvious to future maintainers. utils/meta.go [74-77] } else if i, err := strconv.ParseInt(result, 10, 64); err == nil { return i } else if f, err := strconv.ParseFloat(result, 64); err == nil { - return int64(f) + // Fallback to parsing as float if parsing as int fails + return int64(f) } else { panic("failed to parse int: " + result) Suggestion importance[1-10]: 3 Why: While adding a clarifying comment has some value for maintainability, it's a minor documentation improvement compared to the error handling fix in the first suggestion.	3

[edsonmichaque]

LGTM