Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-10430: fix release pipelines #55

Merged
merged 1 commit into from
Nov 16, 2023
Merged

TT-10430: fix release pipelines #55

merged 1 commit into from
Nov 16, 2023

Conversation

mitjaziv
Copy link
Collaborator

@mitjaziv mitjaziv commented Nov 15, 2023

Description

Change fixes release pipelines for publishing mservctl.

Related Issue

TD-10430

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules dependencies have been updated; run go mod tidy in applicable directories.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • golangci-lint run

@mitjaziv mitjaziv requested a review from a team as a code owner November 15, 2023 19:17
@mitjaziv mitjaziv requested review from umit, komuw and olamilekan000 and removed request for a team November 15, 2023 19:17
Copy link
Member

@umit umit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mitjaziv mitjaziv merged commit 80a3e69 into master Nov 16, 2023
1 check passed
@mitjaziv mitjaziv deleted the fix/release-ci branch November 16, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants