Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-10430: add integration tests for mserv and mservctl #46

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

mitjaziv
Copy link
Collaborator

@mitjaziv mitjaziv commented Nov 12, 2023

Description

Change adds ovh/venom integration test for mserv and mservctl.

Related Issue

TT-10430

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor in applicable directories.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@mitjaziv mitjaziv force-pushed the TT-10430-add-integration branch 7 times, most recently from 10122ec to 9b8bb8d Compare November 12, 2023 17:30
@mitjaziv mitjaziv marked this pull request as ready for review November 12, 2023 17:35
@mitjaziv mitjaziv requested a review from a team as a code owner November 12, 2023 17:35
@mitjaziv mitjaziv requested review from umit and removed request for a team November 12, 2023 17:35
@mitjaziv mitjaziv force-pushed the TT-10430-add-integration branch from 9b8bb8d to 9f321af Compare November 12, 2023 17:36
Copy link

@komuw komuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For integration/bundle/bundle.zip one thing we could do is upload it as a release asset similar to

- name: Attach macOS binary
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ steps.draft-release.outputs.upload_url }}
asset_path: ./${{ env.BINARY_NAME }}.macos.amd64/${{ env.BINARY_NAME }}
asset_name: ${{ env.BINARY_NAME }}.macos.amd64
asset_content_type: application/octet-stream
and that way we wouldn't have to include it in git.
Though I'm not very sure if that would work well.

@mitjaziv mitjaziv force-pushed the TT-10430-add-integration branch 7 times, most recently from 71f1be2 to f18a18d Compare November 13, 2023 20:34
@mitjaziv mitjaziv force-pushed the TT-10430-add-integration branch from f18a18d to 30a58fb Compare November 13, 2023 20:41
@mitjaziv mitjaziv merged commit 7bf77eb into master Nov 13, 2023
1 check passed
@mitjaziv mitjaziv deleted the TT-10430-add-integration branch November 13, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants