ip rl: improved method of getting the IP address #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation was problematic, because if you use any form of reverse proxy or load balancer, the RemoteAddr would appear as the IP address of the load balancer. We need to throw this away as it is not useful for us. This PR checks X-Forwarded-For and X-Real-Ip headers. We still have a shortcoming in that we don't check for private IP subnets. This means that outgoing requests from a client, going via a proxy or gateway, may have a private sub-net in the X-Forwarded-For - these should be filtered out. Finally, we should probably walk backwards through the X-Forwarded-For header, not forwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation was problematic, because if you use any form of reverse proxy or load balancer, the RemoteAddr would appear as the IP address of the load balancer. We need to throw this away as it is not always useful for us.
This PR tweaks the code slightly to check X-Forwarded-For and X-Real-Ip headers.
We still have a shortcoming in that we don't check for private IP subnets. This means that outgoing requests from a client, going via a proxy or gateway, may have a private sub-net in the X-Forwarded-For - these should be filtered out.
Finally, we should probably walk backwards through the X-Forwarded-For header, not forwards.