Improve the name simplification algorithm #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current algorithm will create confusing names in the case of a clash. For example given the two names
box_123
andbox_222
it will simplify these tob
andbo
- it is unclear which of these corresponds to123
and which to222
. The updated algorithm is more symmetric in that it finds the least common prefix required to differentiate between these two, in the example this would bebox_1
andbox_2
.