(baby-project-deployment) #3 Creates a simple deployment action #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusan-turajlic
changed the title
dusan-turajlic
force-pushed
the
adds-deployment-github-action
branch
from
22273e7 to
88e7cfe
Compare
dusan-turajlic
commented
May 16, 2021
OttoFI
requested changes
May 17, 2021
AndreasNasman
approved these changes
May 18, 2021
|
Awesome points you guys @OttoFI and @AndreasNasman thanks for the review. I'll fix these later today and request a new reivew 👍🏼 |
Co-authored-by: Otto Lindén <[email protected]>
Co-authored-by: Otto Lindén <[email protected]>
Co-authored-by: Andreas Näsman <[email protected]>
Co-authored-by: Andreas Näsman <[email protected]>
Co-authored-by: Andreas Näsman <[email protected]>
Co-authored-by: Andreas Näsman <[email protected]>
Co-authored-by: Andreas Näsman <[email protected]>
Co-authored-by: Andreas Näsman <[email protected]>
Co-authored-by: Andreas Näsman <[email protected]>
Changes micro repo to poly repo because that seems to be the more used term
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created the pipline prosess for deploying to the server. This only runs when something has been merged to main. The idea in the future is that each PR will create its own instance of the deployment. But that is something we can add in the future.
The PR deployment will be like a RC (Release Candidate). That way we can test all or latest feautres agenst production before we actualy merge it and it gets deployed to production.
But for now we only have the main branch that is essentaly production