Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with new meteor + mturk versions #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ejolly
Copy link

@ejolly ejolly commented Oct 24, 2019

This PR just tracks some of the changes I played with to get turkserver-meteor working with the new mturk api (unsuccessfully). I'll note here a few other things that need to additionally change for compatibility with the latest Meteor version (currently 1.8):

@mizzao
Copy link
Member

mizzao commented Oct 26, 2019

Thanks for adding me to https://github.com/ejolly/meteor_project_scaffold.

I'm happy to take a look at this next week, probably after we've talked with @ljchang.

@mizzao
Copy link
Member

mizzao commented Nov 4, 2019

@ejolly why do you have api-mturk in this PR instead of aws-sdk? I'm assuming you did some more digging and determined that we should use the official API instead?

@mizzao
Copy link
Member

mizzao commented Nov 4, 2019

@ejolly what is the "import syntax" thing you are mentioning above? I just removed stylus completely in #100.

@ejolly
Copy link
Author

ejolly commented Nov 6, 2019

@ejolly what is the "import syntax" thing you are mentioning above? I just removed stylus completely in #100.

I think back when I was poking around the error I was getting after updating stylus was related to this issue Keyang/node-csvtojson#229, so not stylus per se just a new issue I hit after trying to update stylus. So by import syntax I meant using fs.stats or fs.access instead of fs.exists which seems to be deprecated. I think if turkserver doesn't need it then your fix makes more sense.

@ejolly why do you have api-mturk in this PR instead of aws-sdk? I'm assuming you did some more digging and determined that we should use the official API instead?

Yup exactly. I originally included it because api-mturk is the (confusing) updated version of themturk-apipackage from the same developer, that turkserver was using. Not sure I see any advantage of that over just going with the official `aws-sdk.

@mizzao
Copy link
Member

mizzao commented Nov 6, 2019

Merging #98 and #97 (when completed) should solve all of these issues.

I actually killed stylus altogether in #100 which resolved #94.

I'm not sure if it's worth updating the routing, we can save that for future experiments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants