Release 0.36 #829

penelopeysm · 2025-03-05T10:34:22Z

To include

AbstractPPL 0.11 + change prefixing behaviour #830
Fix condition and fix in submodels #892
Make PrefixContext contain a varname rather than symbol #896
Unify {untyped,typed}_{vector_,}varinfo constructor functions #879
~~A similar PR on SimpleVarInfo constructors~~ Decision has been made to postpone SimpleVarInfo until after accumulators.
Potentially Implement AD testing and benchmarking (hand rolled) #882 or Implement AD testing and benchmarking (with DITest) #883

Closes

Closes AD testing #869
Closes Test linked varinfos in DynamicPPL AD test suite #891

codecov · 2025-03-05T10:45:00Z

Codecov Report

Attention: Patch coverage is 85.39823% with 33 lines in your changes missing coverage. Please review.

Project coverage is 85.05%. Comparing base (cb4ea95) to head (c68f1bb).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/varinfo.jl	74.57%	30 Missing ⚠️
src/utils.jl	71.42%	2 Missing ⚠️
src/contexts.jl	98.41%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
+ Coverage   84.81%   85.05%   +0.24%     
==========================================
  Files          35       35              
  Lines        3846     3922      +76     
==========================================
+ Hits         3262     3336      +74     
- Misses        584      586       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

coveralls · 2025-03-05T10:47:34Z

Pull Request Test Coverage Report for Build 13673973133

Details

0 of 0 changed or added relevant lines in 0 files are covered.
438 unchanged lines in 16 files lost coverage.
Overall coverage decreased (-11.5%) to 73.166%

Files with Coverage Reduction	New Missed Lines	%
ext/DynamicPPLEnzymeCoreExt.jl	1	0.0%
src/experimental.jl	3	0.0%
src/submodel_macro.jl	3	81.08%
src/varinfo.jl	4	82.82%
src/threadsafe.jl	5	67.62%
src/varnamedvector.jl	6	90.37%
src/simple_varinfo.jl	7	78.95%
src/context_implementations.jl	11	81.25%
src/model.jl	11	84.17%
ext/DynamicPPLJETExt.jl	16	0.0%

Totals
Change from base Build 13634518410:	-11.5%
Covered Lines:	2792
Relevant Lines:	3816

💛 - Coveralls

coveralls · 2025-03-05T10:47:34Z

Pull Request Test Coverage Report for Build 13673973133

Details

0 of 0 changed or added relevant lines in 0 files are covered.
438 unchanged lines in 16 files lost coverage.
Overall coverage decreased (-11.5%) to 73.166%

Files with Coverage Reduction	New Missed Lines	%
ext/DynamicPPLEnzymeCoreExt.jl	1	0.0%
src/experimental.jl	3	0.0%
src/submodel_macro.jl	3	81.08%
src/varinfo.jl	4	82.82%
src/threadsafe.jl	5	67.62%
src/varnamedvector.jl	6	90.37%
src/simple_varinfo.jl	7	78.95%
src/context_implementations.jl	11	81.25%
src/model.jl	11	84.17%
ext/DynamicPPLJETExt.jl	16	0.0%

Totals
Change from base Build 13634518410:	-11.5%
Covered Lines:	2792
Relevant Lines:	3816

💛 - Coveralls

coveralls · 2025-03-05T10:47:34Z

Pull Request Test Coverage Report for Build 14616679714

Details

193 of 226 (85.4%) changed or added relevant lines in 13 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.2%) to 85.145%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/contexts.jl	62	63	98.41%
src/utils.jl	5	7	71.43%
src/varinfo.jl	88	118	74.58%

Files with Coverage Reduction	New Missed Lines	%
src/varinfo.jl	2	84.65%
src/varnamedvector.jl	3	90.84%

Totals
Change from base Build 14607812568:	0.2%
Covered Lines:	3336
Relevant Lines:	3918

💛 - Coveralls

github-actions · 2025-03-22T15:53:45Z

Benchmark Report for Commit `c68f1bb`

Computer Information

Julia Version 1.11.5
Commit 760b2e5b739 (2025-04-14 06:53 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

|                 Model | Dimension |  AD Backend |      VarInfo Type | Linked | Eval Time / Ref Time | AD Time / Eval Time |
|-----------------------|-----------|-------------|-------------------|--------|----------------------|---------------------|
| Simple assume observe |         1 | forwarddiff |             typed |  false |                  9.4 |                 1.5 |
|           Smorgasbord |       201 | forwarddiff |             typed |  false |                713.5 |                33.2 |
|           Smorgasbord |       201 | forwarddiff | simple_namedtuple |   true |                295.1 |                62.2 |
|           Smorgasbord |       201 | forwarddiff |           untyped |   true |               1155.5 |                27.4 |
|           Smorgasbord |       201 | forwarddiff |       simple_dict |   true |               3082.1 |                25.0 |
|           Smorgasbord |       201 | reversediff |             typed |   true |               1382.1 |                29.7 |
|           Smorgasbord |       201 |    mooncake |             typed |   true |                902.3 |                 5.3 |
|    Loop univariate 1k |      1000 |    mooncake |             typed |   true |               5260.8 |                 4.0 |
|       Multivariate 1k |      1000 |    mooncake |             typed |   true |                960.5 |                 8.9 |
|   Loop univariate 10k |     10000 |    mooncake |             typed |   true |              58785.0 |                 3.7 |
|      Multivariate 10k |     10000 |    mooncake |             typed |   true |               8132.4 |                10.1 |
|               Dynamic |        10 |    mooncake |             typed |   true |                125.3 |                13.2 |
|              Submodel |         1 |    mooncake |             typed |   true |                 13.8 |                 6.1 |
|                   LDA |        12 | reversediff |             typed |   true |                479.9 |                 5.7 |

* AbstractPPL 0.11; change prefixing behaviour * Use DynamicPPL.prefix rather than overloading

* Unify {Untyped,Typed}{Vector,}VarInfo constructors * Update invocations * NTVarInfo * Fix tests * More fixes * Fixes * Fixes * Fixes * Use lowercase functions, don't deprecate VarInfo * Rewrite VarInfo docstring * Fix methods * Fix methods (really)

…on linked varinfos (#890) * Link VarInfo by default * Tweak interface * Fix tests * Fix interface so that callers can inspect results * Document * Fix tests * Fix changelog * Test linked varinfos Closes #891 * Fix docstring + use AbstractFloat

penelopeysm · 2025-04-16T13:46:36Z

I'll probably take a stab at fixing #857 before merging this.

* Fix conditioning in submodels * Simplify contextual_isassumption * Add documentation * Fix some tests * Add tests; fix a bunch of nested submodel issues * Fix fix as well * Fix doctests * Add unit tests for new functions * Add changelog entry * Update changelog Co-authored-by: Hong Ge <[email protected]> * Finish docs * Add a test for conditioning submodel via arguments * Clean new tests up a bit * Fix for VarNames with non-identity lenses * Apply suggestions from code review Co-authored-by: Markus Hauru <[email protected]> * Apply suggestions from code review * Make PrefixContext contain a varname rather than symbol (#896) --------- Co-authored-by: Hong Ge <[email protected]> Co-authored-by: Markus Hauru <[email protected]>

Release 0.36

061acbe

penelopeysm added 2 commits March 20, 2025 17:58

Merge branch 'main' into breaking

1496868

Merge branch 'main' into breaking

324e623

penelopeysm and others added 8 commits March 25, 2025 19:31

Merge branch 'main' into breaking

bb59885

AbstractPPL 0.11 + change prefixing behaviour (#830)

fc32398

* AbstractPPL 0.11; change prefixing behaviour * Use DynamicPPL.prefix rather than overloading

Remove VarInfo(VarInfo, params) (#870)

cc5e581

Merge remote-tracking branch 'origin/main' into breaking

1b8f555

Merge remote-tracking branch 'origin/main' into breaking

e410f47

Merge remote-tracking branch 'origin/main' into breaking

5ba3530

penelopeysm mentioned this pull request Apr 17, 2025

Fix condition and fix in submodels #892

Merged

14 tasks

penelopeysm and others added 2 commits April 23, 2025 12:09

Merge remote-tracking branch 'origin/main' into breaking

c68f1bb

penelopeysm marked this pull request as ready for review April 23, 2025 12:45

penelopeysm added this pull request to the merge queue Apr 23, 2025

penelopeysm removed this pull request from the merge queue due to a manual request Apr 23, 2025

penelopeysm added this pull request to the merge queue Apr 24, 2025

Merged via the queue into main with commit 23834de Apr 24, 2025
17 of 18 checks passed

penelopeysm deleted the breaking branch April 24, 2025 16:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 0.36 #829

Release 0.36 #829

penelopeysm commented Mar 5, 2025 •

edited

Loading

codecov bot commented Mar 5, 2025 •

edited

Loading

coveralls commented Mar 5, 2025

coveralls commented Mar 5, 2025

coveralls commented Mar 5, 2025 •

edited

Loading

github-actions bot commented Mar 22, 2025 •

edited

Loading

penelopeysm commented Apr 16, 2025

Release 0.36 #829

Release 0.36 #829

Conversation

penelopeysm commented Mar 5, 2025 • edited Loading

To include

Closes

codecov bot commented Mar 5, 2025 • edited Loading

Codecov Report

coveralls commented Mar 5, 2025

Pull Request Test Coverage Report for Build 13673973133

Details

💛 - Coveralls

coveralls commented Mar 5, 2025

Pull Request Test Coverage Report for Build 13673973133

Details

💛 - Coveralls

coveralls commented Mar 5, 2025 • edited Loading

Pull Request Test Coverage Report for Build 14616679714

Details

💛 - Coveralls

github-actions bot commented Mar 22, 2025 • edited Loading

Benchmark Report for Commit c68f1bb

Computer Information

Benchmark Results

penelopeysm commented Apr 16, 2025

penelopeysm commented Mar 5, 2025 •

edited

Loading

codecov bot commented Mar 5, 2025 •

edited

Loading

coveralls commented Mar 5, 2025 •

edited

Loading

github-actions bot commented Mar 22, 2025 •

edited

Loading

Benchmark Report for Commit `c68f1bb`