Drop Zygote dependency and reformat code #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW maybe we should stop testing Zygote on Julia 1.0 - tests run for almost 4 hours now whereas tests on Julia 1.4 were finished after a bit less than 2 hours. Zygote's README also states explicitly:
|
Happy to stop testing Zygote on Julia 1.0. |
|
I removed the Zygote tests on Julia 1.0, unfortunately it seems Github actions don't respect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Zygote dependency, as discussed in #65 (comment). Moreover, currently sometimes the explicit
ZygoteRules.@adjointandZygoteRules.pullbackwas used and sometimes only@adjointandpullback. I reformatted the code (adhering to the 92 characters limit) so that now consistently the more explictZygoteRules.@adjointandZygoteRules.pullbackare used to show clearly that these implementations use Zygote.