Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed node 16 from CI and added node 22 instead #2761

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

smallsaucepan
Copy link
Member

Drop node 16 from CI (end of life was a year ago). Add node 22 instead.

Copy link
Collaborator

@mfedderly mfedderly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically a breaking change because we're dropping node16 official support, but I also think that's fine.

@smallsaucepan
Copy link
Member Author

Thank you both for looking at this.

we're dropping node16 official support

@mfedderly gotcha. In the interests of tidying up, where do we define that? Can't see anything in the readme.

@smallsaucepan smallsaucepan merged commit 7ae02b9 into Turfjs:master Dec 5, 2024
3 checks passed
@mfedderly
Copy link
Collaborator

@smallsaucepan I don't think we define it anywhere, but in other projects I've seen that they make a major semver break when they drop an old node version from support even if nothing else changes. For Node support I think that "We support currently supported versions of Node" is a reasonable policy, with browser support that gets trickier because I kind of expect people using modules other than @turf/turf to be doing their own transpile/polyfilling, but I know not everyone is being careful of every package in node_modules, for instance.

@smallsaucepan smallsaucepan deleted the update-ci-node branch December 5, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants