Add missing Scottish Gaelic translations #21979
Conversation
WalkthroughThis pull request enhances the Gaelic (Scottish Gaelic) localization for the Ghost platform by updating three JSON localization files: Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-authored-by: Cathy Sarisky <[email protected]>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
ghost/i18n/locales/gd/portal.json (1)
185-185:⚠️ Potential issueRestore missing placeholder in translation.
The translation is missing the
{{title}}placeholder which is required for proper variable substitution.- "Unsubscribing from emails will not cancel your paid subscription to {{title}}": "Cuiridh seo stad air puist-d, cha cuir e stad air na tha thu a' pàigheadh airson a bhallrachd agad.", + "Unsubscribing from emails will not cancel your paid subscription to {{title}}": "Cuiridh seo stad air puist-d, cha cuir e stad air na tha thu a' pàigheadh airson a bhallrachd agad air {{title}}."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
ghost/i18n/locales/gd/comments.json(2 hunks)ghost/i18n/locales/gd/newsletter.json(1 hunks)ghost/i18n/locales/gd/portal.json(8 hunks)
🔇 Additional comments (1)
ghost/i18n/locales/gd/comments.json (1)
Line range hint
13-63: LGTM! Translations are complete and accurate.All placeholders are correctly maintained and translations are culturally appropriate.
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
ghost/i18n/locales/gd/portal.json (1)
Line range hint
210-211: Fix incorrect variable names in translations.The translations use
{{expiryDate}}but the source strings use{{renewalDate}}and{{subscriptionStart}}respectively. This mismatch will cause the variables to not be replaced correctly.Apply this diff to fix the variable names:
- "Your subscription will renew on {{renewalDate}}": "Ath-nuadhaichidh am fo-sgrìobhadh agad: {{expiryDate}}", - "Your subscription will start on {{subscriptionStart}}": "Tòisichidh am fo-sgrìobhadh agad: {{expiryDate}}" + "Your subscription will renew on {{renewalDate}}": "Ath-nuadhaichidh am fo-sgrìobhadh agad: {{renewalDate}}", + "Your subscription will start on {{subscriptionStart}}": "Tòisichidh am fo-sgrìobhadh agad: {{subscriptionStart}}"
♻️ Duplicate comments (1)
ghost/i18n/locales/gd/portal.json (1)
185-185:⚠️ Potential issueAdd missing variable in translation string.
The translation is missing the
{{title}}variable which is present in the source string.
🧹 Nitpick comments (2)
ghost/i18n/locales/gd/portal.json (2)
70-81: Ensure consistent punctuation in error messages.The error messages should maintain consistent punctuation. Some messages end with periods while others don't.
Apply this diff to maintain consistency:
-"Failed to cancel subscription, please try again": "Dh'fhàillig dùbhadh às an fho-sgrìobhaidh, feuch a-rithist", +"Failed to cancel subscription, please try again": "Dh'fhàillig dùbhadh às an fho-sgrìobhaidh, feuch a-rithist.", -"Failed to log in, please try again": "Dh'fhàillig clàradh a-steach, feuch a-rithist", +"Failed to log in, please try again": "Dh'fhàillig clàradh a-steach, feuch a-rithist.", -"Failed to log out, please try again": "Dh'fhàillig clàradh a-mach, feuch a-rithist", +"Failed to log out, please try again": "Dh'fhàillig clàradh a-mach, feuch a-rithist.", -"Failed to process checkout, please try again": "Dh'fhàillig a' cheannachd", +"Failed to process checkout, please try again": "Dh'fhàillig a' cheannachd.", -"Failed to send magic link email": "Dh'fhàillig cur a' phuist-d", +"Failed to send magic link email": "Dh'fhàillig cur a' phuist-d.", -"Failed to send verification email": "Dh'fhàillig cur a' phuist-d", +"Failed to send verification email": "Dh'fhàillig cur a' phuist-d.", -"Failed to sign up, please try again": "Dh'fhàillig clàradh", +"Failed to sign up, please try again": "Dh'fhàillig clàradh.", -"Failed to update account data": "Dh'fhàillig ùrachadh a' chunntais", +"Failed to update account data": "Dh'fhàillig ùrachadh a' chunntais.", -"Failed to update account details": "Dh'fhàillig ùrachadh a' chunntais", +"Failed to update account details": "Dh'fhàillig ùrachadh a' chunntais.",
173-178: Ensure consistent pluralization in time-based messages.The translations should handle pluralization correctly for different time units (days, hours, minutes).
Consider using a more sophisticated pluralization system that can handle singular/plural forms correctly. For example:
- 1 day vs 2 days (1 là vs 2 làithean)
- 1 hour vs 2 hours (1 uair vs 2 uairean)
- 1 minute vs 2 minutes (1 mhionaid vs 2 mhionaidean)
Add missing Scottish Gaelic translations