Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Added and improved Dutch translations #21959

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Conversation

VirtualRoy
Copy link
Contributor

Hey there,

I completed some missing translation keys and found a few translation errors I adjusted. I'm a Dutch native, but feel free to double-check the edits.

Thanks for building such awesome software for us to enjoy! ✨

Copy link

coderabbitai bot commented Jan 20, 2025

Walkthrough

This pull request focuses on improving Dutch localization for two JSON files in the Ghost project: comments.json and portal.json. The changes involve adding missing translations, updating existing translations for better clarity, and ensuring that various user interface strings are accurately translated into Dutch. The modifications cover a range of phrases related to comments, user interactions, and site membership.

Changes

File Changes
ghost/i18n/locales/nl/comments.json - Added/updated translations for phrases like "{{amount}} more", "Are you sure?", "Deleted", "Deleting"
- Translated "Hidden for members", "Load more", "Once deleted" messages
- Added time-related translations like "One hour ago", "One min ago"
- Updated "Reply to", "Replied to", "Sort by" translations
ghost/i18n/locales/nl/portal.json - Changed "Get help" translation from "Lees meer" to "Krijg hulp"
- Added translation for "This site only accepts paid members"
- Slightly rephrased login link instruction translation

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@cathysarisky cathysarisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!

ghost/i18n/locales/nl/comments.json Outdated Show resolved Hide resolved
🌐Adjusted "replied to" value
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
ghost/i18n/locales/nl/comments.json (1)

44-45: Consider using consistent time indicators.

The translations "Eén uur geleden" and "Eén min geleden" use different abbreviations for time units (full "uur" vs abbreviated "min"). Consider using either both full forms or both abbreviated forms for consistency.

-    "One min ago": "Eén min geleden",
+    "One min ago": "Eén minuut geleden",
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7144db and 478d7a6.

📒 Files selected for processing (2)
  • ghost/i18n/locales/nl/comments.json (3 hunks)
  • ghost/i18n/locales/nl/portal.json (3 hunks)
🔇 Additional comments (6)
ghost/i18n/locales/nl/comments.json (3)

6-6: LGTM! Accurate and natural Dutch translations.

The translations are grammatically correct and maintain a consistent tone. "Wordt verwijderd" appropriately conveys the ongoing action of deletion.

Also applies to: 13-13, 20-22


47-47: LGTM! Clear distinction between tenses.

The translations correctly differentiate between past tense ("Geantwoord op") and present tense ("Antwoord op"), addressing the previous reviewer's concern about potential confusion.

Also applies to: 49-49


63-63: LGTM! Correct preposition usage.

The translation "Sorteren op" correctly uses the Dutch preposition "op" for sorting context.

ghost/i18n/locales/nl/portal.json (3)

14-14: LGTM! Improved formality.

The use of "Controleer" instead of "Check" is a good improvement, using more proper Dutch vocabulary while maintaining clarity.


84-84: LGTM! Fixed incorrect translation.

The change from "Lees meer" (Read more) to "Krijg hulp" (Get help) correctly aligns with the English meaning.


170-170: LGTM! Clear and consistent translation.

The translation "Deze site accepteert alleen betalende leden" is accurate and maintains consistency with other membership-related terminology in the file.

Copy link
Contributor

@cathysarisky cathysarisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@9larsons 9larsons merged commit 0404d19 into TryGhost:main Jan 28, 2025
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants