-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Added and improved Dutch translations #21959
Conversation
WalkthroughThis pull request focuses on improving Dutch localization for two JSON files in the Ghost project: Changes
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution!
🌐Adjusted "replied to" value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
ghost/i18n/locales/nl/comments.json (1)
44-45
: Consider using consistent time indicators.The translations "Eén uur geleden" and "Eén min geleden" use different abbreviations for time units (full "uur" vs abbreviated "min"). Consider using either both full forms or both abbreviated forms for consistency.
- "One min ago": "Eén min geleden", + "One min ago": "Eén minuut geleden",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
ghost/i18n/locales/nl/comments.json
(3 hunks)ghost/i18n/locales/nl/portal.json
(3 hunks)
🔇 Additional comments (6)
ghost/i18n/locales/nl/comments.json (3)
6-6
: LGTM! Accurate and natural Dutch translations.The translations are grammatically correct and maintain a consistent tone. "Wordt verwijderd" appropriately conveys the ongoing action of deletion.
Also applies to: 13-13, 20-22
47-47
: LGTM! Clear distinction between tenses.The translations correctly differentiate between past tense ("Geantwoord op") and present tense ("Antwoord op"), addressing the previous reviewer's concern about potential confusion.
Also applies to: 49-49
63-63
: LGTM! Correct preposition usage.The translation "Sorteren op" correctly uses the Dutch preposition "op" for sorting context.
ghost/i18n/locales/nl/portal.json (3)
14-14
: LGTM! Improved formality.The use of "Controleer" instead of "Check" is a good improvement, using more proper Dutch vocabulary while maintaining clarity.
84-84
: LGTM! Fixed incorrect translation.The change from "Lees meer" (Read more) to "Krijg hulp" (Get help) correctly aligns with the English meaning.
170-170
: LGTM! Clear and consistent translation.The translation "Deze site accepteert alleen betalende leden" is accurate and maintains consistency with other membership-related terminology in the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hey there,
I completed some missing translation keys and found a few translation errors I adjusted. I'm a Dutch native, but feel free to double-check the edits.
Thanks for building such awesome software for us to enjoy! ✨