Skip to content

🔒 Made names for uploaded files more secure and resilient to filesystems' limits #15811

🔒 Made names for uploaded files more secure and resilient to filesystems' limits

🔒 Made names for uploaded files more secure and resilient to filesystems' limits #15811

Triggered via pull request January 29, 2025 12:05
Status Cancelled
Total duration 7m 10s
Artifacts 1

ci.yml

on: pull_request
Matrix: job_unit-tests
Matrix: job_database-tests
Admin tests - Chrome
3m 35s
Admin tests - Chrome
Matrix: job_regression-tests
Performance tests
0s
Performance tests
Coverage
0s
Coverage
Publish @tryghost/admin-x-activitypub
0s
Publish @tryghost/admin-x-activitypub
All required tests passed or skipped
0s
All required tests passed or skipped
Fit to window
Zoom out
Zoom in

Annotations

21 errors and 6 warnings
Regression tests (Node 20.11.1, sqlite3)
Process completed with exit code 1.
Regression tests (Node 20.11.1, mysql8)
The job was canceled because "_20_11_1_sqlite3_testing" failed.
Regression tests (Node 20.11.1, mysql8)
The operation was canceled.
Database tests (Node 20.11.1, sqlite3)
Process completed with exit code 1.
Database tests (Node 18.12.1, mysql8)
The job was canceled because "_20_11_1_sqlite3_testing" failed.
Database tests (Node 20.11.1, mysql8)
The job was canceled because "_20_11_1_sqlite3_testing" failed.
Database tests (Node 20.11.1, mysql8)
The operation was canceled.
Unit tests (Node 20.11.1)
Process completed with exit code 1.
Unit tests (Node 18.12.1)
The job was canceled because "_20_11_1" failed.
Unit tests (Node 18.12.1)
The operation was canceled.
Lint
Canceling since a higher priority waiting request for 'update-storage-adapter-to-use-secured-filenames' exists
Lint
The operation was canceled.
Admin tests - Chrome
Canceling since a higher priority waiting request for 'update-storage-adapter-to-use-secured-filenames' exists
Admin tests - Chrome
The operation was canceled.
Ghost-CLI tests
Canceling since a higher priority waiting request for 'update-storage-adapter-to-use-secured-filenames' exists
Ghost-CLI tests
The operation was canceled.
Signup-form tests
Canceling since a higher priority waiting request for 'update-storage-adapter-to-use-secured-filenames' exists
Signup-form tests
The operation was canceled.
Admin-X Settings tests
Canceling since a higher priority waiting request for 'update-storage-adapter-to-use-secured-filenames' exists
Admin-X Settings tests
The operation was canceled.
All required tests passed or skipped
Process completed with exit code 1.
Regression tests (Node 20.11.1, sqlite3): ghost/core/test/regression/api/admin/authentication.test.js#L100
Retried 'Authentication API Blog setup complete setup' due to 'The theme dawn should have been installed'
Regression tests (Node 20.11.1, sqlite3): ghost/core/test/regression/api/admin/authentication.test.js#L77
Retried 'Authentication API Blog setup complete setup' due to '"response.body" is missing the expected property "users" Snapshot name: `Authentication API Blog setup complete setup 1: [body] 1` - Expected properties - 3 + Received value + 10 Object { - "users": Array [ + "errors": Array [ Object { - "created_at": StringMatching /\\d\{4\}-\\d\{2\}-\\d\{2\}T\\d\{2\}:\\d\{2\}:\\d\{2\}\\\.000Z/, - "updated_at": StringMatching /\\d\{4\}-\\d\{2\}-\\d\{2\}T\\d\{2\}:\\d\{2\}:\\d\{2\}\\\.000Z/, + "code": null, + "context": null, + "details": null, + "ghostErrorCode": null, + "help": null, + "id": "d332d200-de39-11ef-b472-07c4f543f0fa", + "message": "Setup has already been completed.", + "property": null, + "type": "NoPermissionError", }, ], }'
Database tests (Node 20.11.1, sqlite3): ghost/core/test/e2e-api/admin/files.test.js#L32
Retried 'Files API Can upload a file' due to 'expected 'http://127.0.0.1:2369/content/files/2025/01/loadingcat_square-c1f5c460a9cfcfda.gif' to match /http:\/\/127.0.0.1:2369\/content\/files\/\d+\/\d+\/loadingcat_square.gif/'
Database tests (Node 20.11.1, sqlite3): ghost/core/test/e2e-api/admin/files.test.js#L32
Retried 'Files API Can upload a file' due to 'expected 'http://127.0.0.1:2369/content/files/2025/01/loadingcat_square-25fe9f343a34424b.gif' to match /http:\/\/127.0.0.1:2369\/content\/files\/\d+\/\d+\/loadingcat_square.gif/'
Signup-form tests
No files were found with the provided path: apps/signup-form/playwright-report. No artifacts will be uploaded.
Admin-X Settings tests
No files were found with the provided path: apps/admin-x-settings/playwright-report. No artifacts will be uploaded.

Artifacts

Produced during runtime
Name Size
comments-ui-playwright-report
229 KB