Update scikit-learn requirement to >=0.22.2,<1.4.0

[jamesmyatt]

Description

Scikit-learn 1.1.x is over 1 year old. Also Python 3.10 is over 2 years old.

Fixes #1953,
Replaces #1964

Type of change

Please check all relevant options.

• Improvement (non-breaking)
• Bug fix (non-breaking)
• New feature (non-breaking)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

• CI

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• My changes have been tested using both CPU and GPU devices

[beat-buesser]

Hi @jamesmyatt Thank you very much! I have started the unit-test workflows for this PR.

[jamesmyatt]

@beat-buesser There seems to be a problem with Codecov:

[2023-12-13T14:18:25.530Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7e91dd) 84.02% compared to head (63339b2) 21.24%.
Report is 10 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2346       +/-   ##
===========================================
- Coverage   84.02%   21.24%   -62.79%     
===========================================
  Files         324      324               
  Lines       29988    29331      -657     
  Branches     5539     5028      -511     
===========================================
- Hits        25198     6230    -18968     
- Misses       3374    22982    +19608     
+ Partials     1416      119     -1297     

see 262 files with indirect coverage changes

[beat-buesser]

Hi @jamesmyatt Could you please take a look at one of the new runs? It seems that Python 3.11 is not yet available. I suggest we remove the second new run for Python 3.11 and also remove the oldest run for 0.24.2.

[jamesmyatt]

Removing 0.24.2 makes sense.

Looks like the issue for python 3.11 is the version of numba that's pinned for the tests. That probably needs updating too.

[beat-buesser]

You're right. Can you try if it is possible to upgrade numba too? If I remember correctly it depends on the numpy version.

[jamesmyatt]

@beat-buesser Can you approve the workflows, please?

[beat-buesser]

Fixed by #2372