[ACL-264] CI, dependencies, example project and changelog updates #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dili91
changed the title
dili91
commented
Jan 10, 2025
There was a problem hiding this comment.
I havent' been able to try this yet, but I'm fairly confident
dili91
commented
Jan 10, 2025
There was a problem hiding this comment.
I've generated this with the help of scripts + gen AI. Looks fine!
dili91
commented
Jan 10, 2025
There was a problem hiding this comment.
These changes are coming from the Quarkus upgrade
dili91
commented
Jan 10, 2025
Comment on lines
+20
to
+24
| // Reference to the library version that's local to this project! | ||
| // Check out the main README for instructions on how to install | ||
| // the library in your project! | ||
| // https://github.com/TrueLayer/truelayer-java?tab=readme-ov-file#stable-releases | ||
| implementation 'com.truelayer:truelayer-java' |
There was a problem hiding this comment.
We reference the local project, not via Maven. This should help us verifying builds at CI time on the latest library version
dili91
commented
Jan 10, 2025
There was a problem hiding this comment.
Usual wrapper updates
dili91
commented
Jan 10, 2025
There was a problem hiding this comment.
I've added linting to the sample project as well. I've not changed anything otherwise
dili91
commented
Jan 10, 2025
Comment on lines
+8
to
+12
| quarkus.otel.trace.enabled=true | ||
| quarkus.otel.metrics.enabled=true | ||
| quarkus.otel.logs.enabled=true | ||
| quarkus.application.name=quarkus-mvc | ||
| quarkus.otel.exporter.otlp.endpoint=http://localhost:4317 |
There was a problem hiding this comment.
I've been doing some experiments in preparation for #336
tl-luca-baggi
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes a bunch of setup-related updates, and a minimal bump for our test and lint tooling:
Type of change
Please select multiple options if required.
Checklist:
gradle.propertiesfile with the new versionCHANGELOG.mdfile with the details of the new version