Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that cordova is injected only once on android #33

Closed
wants to merge 1 commit into from

Conversation

pgaubatz
Copy link

This fixes #15

@tisdall
Copy link

tisdall commented Jun 27, 2017

I'm unfamiliar with Android development, but is there any way to detect that the webview is crosswalk before bothering to search for the script in the DOM?

@pgaubatz
Copy link
Author

Hi @tisdall
not that I'm aware of.
But what exactly is your concern?

@tisdall
Copy link

tisdall commented Jul 3, 2017

Well, the issue is only applicable to Crosswalk, so if there was a quick way to detect Crosswalk before searching through the DOM then it'd probably be faster. This is really an issue in Crosswalk so it'd probably be better to encapsulate it in a "if crosswalk then" type statement.

@pgaubatz pgaubatz closed this Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement for Ajax-Pages / Crosswalk related issue
2 participants