Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for Ajax-Pages / Crosswalk related issue #15

Open
atroy opened this issue Oct 11, 2016 · 7 comments · Fixed by leo-buneev/cordova-plugin-remote-injection#1
Labels

Comments

@atroy
Copy link

atroy commented Oct 11, 2016

Add a setting for ajax-pages, so that they do not include cordova on every request. Eg. <preference name="CRIOnlyInjectOnce" value="true" />

Or is there another way to detect if the request is ajax?

@bradleyjames
Copy link
Collaborator

bradleyjames commented Oct 11, 2016

Can you provide more information on your setup? What OS? What version of cordova and the platform specific package (i.e cordova --version and cordova platform)? If iOS is this with the UIWebView or the WKWebView?

The reason I ask is that the injection should only occur for the top level page being loading in the webview. What that page does shouldn't be visible to the plugin so I'm curious of the details of the use case displaying this behavior.

@atroy
Copy link
Author

atroy commented Oct 11, 2016

Hi, cordova version is 6.3.1 and platform is android, but with crosswalk-webview-plugin. I get a "onPageFinished" everytime but only a single time "onPageStarted". If I have time I will check if this happens w/o crosswalk.

@bradleyjames
Copy link
Collaborator

Ah, crosswalk. I haven't tested it in crosswalk yet. Let me know what you find out.

Off the top of my head I should be checking the content type before injecting. I'll see if I have access to that.

@atroy
Copy link
Author

atroy commented Oct 12, 2016

Ok.. it is crosswalk related.. sorry for the noise. It seems that crosswalk kicks onPageFinished events on ajax calls, and the system webview does not. But I would recommend that you mention this in the readme or something, so other devs would be warned. Thanks

@atroy atroy closed this as completed Oct 12, 2016
@atroy atroy changed the title Improvement for Ajax-Pages Improvement for Ajax-Pages / Crosswalk related issue Oct 12, 2016
@bradleyjames
Copy link
Collaborator

I'm not against looking at things on my side to see if I make it work. Reopening and thanks for the report.

@atroy
Copy link
Author

atroy commented Nov 15, 2016

Hi do you have any news for me? Have you tried it on xwalk?

@bradleyjames
Copy link
Collaborator

Sorry, I have not. I'm not sure when I'll be able to but I'll keep it in the back of my mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants