Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS-8443 Update Bhyve SMBIOS Manufacturer #472

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OS-8443 Update Bhyve SMBIOS Manufacturer #472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion usr/src/lib/brand/bhyve/zone/boot.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

/*
* Copyright 2020 Joyent, Inc.
* Copyright 2024 MNX Cloud, Inc.
*/

/*
Expand Down Expand Up @@ -143,7 +144,7 @@ add_smbios(int *argc, char **argv)
* This is based upon the SMBIOS values we expose to KVM guests.
*/
(void) snprintf(smbios, sizeof (smbios),
"1,manufacturer=Joyent,product=SmartDC HVM,version=7.%s,"
"1,manufacturer=Triton Data Center,product=Triton HVM,version=7.%s,"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The product at least needs to stay SmartDC HVM. Changing this will definitely break cloud-init that HVM images rely on. Even if we changed upstream cloud-init, all existing images wouldn't get that change.

"serial=%s,sku=001,family=Virtual Machine",
version, zonename);

Expand Down