Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS-8584 Introduce gcc14 as the shadow-compiler #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tsoome
Copy link
Contributor

@tsoome tsoome commented Oct 31, 2024

we need few patches to get illumos-extra to build with gcc 14.

@danmcd
Copy link
Contributor

danmcd commented Nov 5, 2024

Since late-joyent and MNX, I've been trying to use XXX SmartOS in places to indicate gross things; makes it easier to git grep.

@danmcd
Copy link
Contributor

danmcd commented Nov 5, 2024

I'm also shocked you didn't need this:

899c842

But I think that's because your strap is still being built with build-zone's compiler (which is gcc10 on 21.4.x build zones).

danmcd
danmcd previously approved these changes Nov 12, 2024
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems clean & compact.

@@ -122,6 +122,7 @@ LIBSTDCXXVER_6 = 6.0.22
LIBSTDCXXVER_7 = 6.0.24
LIBSTDCXXVER_9 = 6.0.28
LIBSTDCXXVER_10 = 6.0.28
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants