-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the 9.6/9.8 GHC API #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rest are all instance of same, something with "add to the context of an inferred type"
This reverts commit 01b35af.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the weird intermediate states of refactoring the modules etc. in 9.0->9.4, we've finally updated PropR to 9.8!
At least so far as it passes the test-suite.
There was some weirdness we had to work around:
-XPartialTypeSignatures
changed in an undocumented way, so we now add_ =>
in front of types to infer constraints as well. See 24425 for more info!3.10
and new cabal format.SrcSpan
toSrcAnn
. This also required us to define orphan instances forOrd
andEq
for these.guessTarget
now instead of making them on the fly due to targets now includingHomeUnit
.parseDynamicFlags
on startup for thecheck-helpers
package to be visible! Otherwise the package infrastructure is not initialized?check-helpers
meaning we don't need to installQuickCheck
explicitly.ghc_flags
that allow users to set theghc
flags for the repair.LinkInMemory
andHscInterpreted
instead of thehsc_target
.9.6
(which is recommended by GHCup) and9.8
, the latest. This is facilitated by a few pre-processsing pragmas, but nothing major.GhcPs
specific. This is due to (I belive) the new annotations on locations that vary between phases? In any case, I followed the types.