Scripts/Spells: Updated paladin script for spell Blinding Light #30609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyr97
reviewed
Jan 19, 2025
| } | ||
|
|
||
| void Register() override | ||
| { | ||
| OnEffectHitTarget += SpellEffectFn(spell_pal_blinding_light::HandleDummy, EFFECT_0, SPELL_EFFECT_APPLY_AURA); | ||
| OnHit += SpellHitFn(spell_pal_blinding_light::HandleOnHit); |
There was a problem hiding this comment.
why not OnEffectHitTarget? I'm curious
There was a problem hiding this comment.
I think he might have a sort of mixed thought: since the triggered spell uses AoE target as TargetB, he might have thought that he doesn't need to hook to OnEffectHitTarget. However, the main spell uses TARGET_UNIT_CASTER, so OnEffectHitTarget should be ok here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Tests performed:
Tested in-game