Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Windows x64 build #8234

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Added Windows x64 build #8234

merged 1 commit into from
Oct 28, 2024

Conversation

qstokkink
Copy link
Contributor

@qstokkink qstokkink commented Oct 28, 2024 •
edited
Loading

Fixes #8233

This PR:

  • Adds a real x64 and a real x86 Windows build (previous was x64 pretending to be x86).
  • Removes the unused build/win/locate-python.py script.
  • Updates the build script to use vcpkg for external dependencies.

Notes:

@qstokkink
Added Windows x64 build
ec91300 
And some minor cleanup of the build script.
@qstokkink qstokkink marked this pull request as ready for review October 28, 2024 14:28
@qstokkink qstokkink changed the title WIP: Added Windows x64 build READY: Added Windows x64 build Oct 28, 2024
@qstokkink qstokkink changed the title READY: Added Windows x64 build Added Windows x64 build Oct 28, 2024
@qstokkink qstokkink merged commit 8594e11 into Tribler:main Oct 28, 2024
7 checks passed
@qstokkink qstokkink deleted the add_win64_build branch October 28, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a real x64 Windows build
2 participants
@qstokkink @egbertbouman