Fix video streaming endpoint #8212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egbertbouman
force-pushed
the
fix_stream_ep
branch
5 times, most recently
from
fc92d15
to
a038361
Compare
egbertbouman
force-pushed
the
fix_stream_ep
branch
from
a038361
to
1348c26
Compare
|
validate |
qstokkink
reviewed
Oct 15, 2024
| from pathlib import Path, PurePosixPath | ||
| from typing import TYPE_CHECKING, Any, Optional, TypedDict, cast | ||
|
|
||
| import libtorrent as lt | ||
| from aiohttp import web | ||
| from aiohttp.web_exceptions import HTTPPartialContent, HTTPRequestRangeNotSatisfiable |
There was a problem hiding this comment.
Interesting: I never knew this existed. I guess we should start using this elsewhere, in Tribler and IPv8, too.
qstokkink
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the video streaming endpoint.
Once merged you can stream MP4s directly from the browser by going to
/api/downloads/<infohash>/stream/<fileindex>.