Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added workaround for deprecation of macos-12 runner #8203

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

qstokkink
Copy link
Contributor

@qstokkink qstokkink commented Oct 11, 2024

Fixes #8200

This PR:

  • Updates the unit tests to use macos-14 instead of macos-12.
  • Updates create_torrent_file to use the v1_only flag.
  • Removes macos-12 from the build job.

@qstokkink qstokkink force-pushed the upd_unitt_macos14 branch 9 times, most recently from 799c672 to 133b037 Compare October 11, 2024 08:33
@qstokkink
Copy link
Contributor Author

qstokkink commented Oct 11, 2024

It seems like the newest libtorrent version demands a minimum piece size of 16384 for v2-compatible torrents. From the libtorrent source, I gather that passing the v1_only flag may fix this.

flags = lt.create_torrent_flags_t.optimize

That said, this flag is so new that it doesn't exist on our typing yet, or in lt.create_torrent_flags_t, and we'll have to manually insert the integer value.

UPDATE: This is a confirmed fix.

@qstokkink qstokkink changed the title WIP: Added workaround for deprecation of macos-12 runner READY: Added workaround for deprecation of macos-12 runner Oct 11, 2024
@qstokkink qstokkink marked this pull request as ready for review October 11, 2024 09:41
@qstokkink qstokkink changed the title READY: Added workaround for deprecation of macos-12 runner Added workaround for deprecation of macos-12 runner Oct 11, 2024
@qstokkink qstokkink merged commit 9f2c947 into Tribler:main Oct 11, 2024
7 checks passed
@qstokkink qstokkink deleted the upd_unitt_macos14 branch October 11, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Libtorrent is not available for GitHub Actions CI
2 participants