Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8 headless #8178

Merged
merged 1 commit into from
Sep 26, 2024
Merged

v8 headless #8178

merged 1 commit into from
Sep 26, 2024

Conversation

Dmole
Copy link
Contributor

@Dmole Dmole commented Sep 25, 2024

Fixes #8176

This PR:

  • Fixes / re-adds the ability to operate in server/headless mode

egbertbouman
egbertbouman reviewed Sep 26, 2024
View reviewed changes
Copy link
Member

@egbertbouman egbertbouman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It looks good to me, but maybe you could try and fix the ruff issues? If you move some blocks of code out of main and into separate functions, it will probably be OK (e.g. the config creation and torrent URI loading).

@egbertbouman
Copy link
Member

validate

egbertbouman
egbertbouman approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@egbertbouman egbertbouman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@egbertbouman egbertbouman merged commit 9b4bea8 into Tribler:main Sep 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v8 headless
2 participants
@Dmole @egbertbouman