Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various version related fixes #8135

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Various version related fixes #8135

merged 2 commits into from
Sep 5, 2024

Conversation

qstokkink
Copy link
Contributor

Fixes #8134
Fixes #8133

This PR:

  • Fixes missing METADATA file generation.
  • Fixes the libtorrent user agent being set to Tribler/Experimental.
  • Removes sharing the IPv8 public key through libtorrent.

Note that PyInstaller does support metadata generation. However, I'd like the tribler.spec and setup.py to remain pretty close.

@qstokkink qstokkink changed the title Fix user agent Various version related fixes Sep 5, 2024
@qstokkink qstokkink marked this pull request as ready for review September 5, 2024 08:34
@qstokkink qstokkink changed the title Various version related fixes READY: Various version related fixes Sep 5, 2024
@qstokkink qstokkink changed the title READY: Various version related fixes Various version related fixes Sep 5, 2024
@qstokkink qstokkink merged commit c756295 into Tribler:main Sep 5, 2024
7 checks passed
@qstokkink qstokkink deleted the fix_user_agent branch September 5, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build is reporting its version is git User agent still set to experimental
2 participants
@qstokkink @egbertbouman