Updated libtorrent session creation to be async #8112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qstokkink
force-pushed
the
upd_dlmngr_session_futures
branch
from
aa9ef3f
to
b05fd19
Compare
qstokkink
changed the title
qstokkink
changed the title
qstokkink
force-pushed
the
upd_dlmngr_session_futures
branch
4 times, most recently
from
50f0822
to
541e7b2
Compare
qstokkink
changed the title
egbertbouman
reviewed
Sep 2, 2024
There was a problem hiding this comment.
Looks fine, but maybe you can remove some of the add_done_callback calls in favor of awaiting? There are definitely some cases where you can avoid its use. Some (untested) ideas:
- make
initializeasync (shouldn't be a problem, since it's called bySession.start) - make
_request_torrent_updatesasync (shouldn't be a problem, since it's only called using theTaskManager) - make
set_download_rate_limitasync (although you'll have to useTaskManagerinDownloadManager.__init__) - use
awaitinDownloadManager.shutdown - use
awaitinDownloadManager.remove_download
qstokkink
changed the title
qstokkink
force-pushed
the
upd_dlmngr_session_futures
branch
from
541e7b2
to
27e6f10
Compare
qstokkink
force-pushed
the
upd_dlmngr_session_futures
branch
from
27e6f10
to
ddc4144
Compare
qstokkink
changed the title
|
@egbertbouman I implemented your suggestions. In addition, I made I validated locally that downloading still works, even after shutting down and restarting Tribler. |
egbertbouman
approved these changes
Sep 2, 2024
qstokkink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8060
This PR:
DownloadManager.ltsessionsto store futures instead of completed sessions.