Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Docker build action #8108

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Conversation

qstokkink
Copy link
Contributor

@qstokkink qstokkink commented Aug 22, 2024

Fixes #8105

This PR:

  • Adds a Docker image build action.

The latest build is available here: https://github.com/qstokkink/tribler/actions/runs/10506075807

@qstokkink qstokkink changed the title WIP: Added Docker build action READY: Added Docker build action Aug 22, 2024
@qstokkink qstokkink marked this pull request as ready for review August 22, 2024 10:22
@xoriole
Copy link
Contributor

xoriole commented Aug 26, 2024

The docker image is requiring the DISPLAY, and is failing with the following stacktrace:

Traceback (most recent call last):
  File "/app/tribler/src/run_tribler.py", line 14, in <module>
    import pystray
  File "/usr/local/lib/python3.10/site-packages/pystray/__init__.py", line 64, in <module>
    Icon = backend().Icon
  File "/usr/local/lib/python3.10/site-packages/pystray/__init__.py", line 56, in backend
    return candidate()
  File "/usr/local/lib/python3.10/site-packages/pystray/__init__.py", line 36, in xorg
    from . import _xorg as backend; return backend
  File "/usr/local/lib/python3.10/site-packages/pystray/_xorg.py", line 36, in <module>
    display = Xlib.display.Display()
  File "/usr/local/lib/python3.10/site-packages/Xlib/display.py", line 89, in __init__
    self.display = _BaseDisplay(display)
  File "/usr/local/lib/python3.10/site-packages/Xlib/display.py", line 71, in __init__
    protocol_display.Display.__init__(self, *args, **keys)
  File "/usr/local/lib/python3.10/site-packages/Xlib/protocol/display.py", line 84, in __init__
    name, protocol, host, displayno, screenno = connect.get_display(display)
  File "/usr/local/lib/python3.10/site-packages/Xlib/support/connect.py", line 73, in get_display
    return mod.get_display(display)
  File "/usr/local/lib/python3.10/site-packages/Xlib/support/unix_connect.py", line 59, in get_display
    raise error.DisplayNameError(display)
Xlib.error.DisplayNameError: Bad display name ""

@qstokkink
Copy link
Contributor Author

That should be resolved by https://stackoverflow.com/a/44434831

@qstokkink qstokkink changed the title READY: Added Docker build action WIP: Added Docker build action Aug 26, 2024
@qstokkink qstokkink marked this pull request as draft August 26, 2024 10:59
@qstokkink
Copy link
Contributor Author

Another issue: this build does not package the npm output (yet).

@qstokkink qstokkink changed the title WIP: Added Docker build action READY: Added Docker build action Aug 28, 2024
@qstokkink qstokkink marked this pull request as ready for review August 28, 2024 13:29
@qstokkink qstokkink changed the title READY: Added Docker build action Added Docker build action Aug 28, 2024
@qstokkink qstokkink changed the title Added Docker build action READY: Added Docker build action Aug 28, 2024
@qstokkink qstokkink force-pushed the add_docker_build branch 3 times, most recently from 74e44dc to 9ef96c2 Compare August 29, 2024 12:40
@qstokkink qstokkink changed the title READY: Added Docker build action Added Docker build action Sep 2, 2024
@qstokkink qstokkink merged commit b053617 into Tribler:main Sep 2, 2024
7 checks passed
@qstokkink qstokkink deleted the add_docker_build branch September 2, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add Docker build Action
3 participants