-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Docker build action #8108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qstokkink
changed the title
WIP: Added Docker build action
READY: Added Docker build action
Aug 22, 2024
This was referenced Aug 22, 2024
The docker image is requiring the DISPLAY, and is failing with the following stacktrace: Traceback (most recent call last):
File "/app/tribler/src/run_tribler.py", line 14, in <module>
import pystray
File "/usr/local/lib/python3.10/site-packages/pystray/__init__.py", line 64, in <module>
Icon = backend().Icon
File "/usr/local/lib/python3.10/site-packages/pystray/__init__.py", line 56, in backend
return candidate()
File "/usr/local/lib/python3.10/site-packages/pystray/__init__.py", line 36, in xorg
from . import _xorg as backend; return backend
File "/usr/local/lib/python3.10/site-packages/pystray/_xorg.py", line 36, in <module>
display = Xlib.display.Display()
File "/usr/local/lib/python3.10/site-packages/Xlib/display.py", line 89, in __init__
self.display = _BaseDisplay(display)
File "/usr/local/lib/python3.10/site-packages/Xlib/display.py", line 71, in __init__
protocol_display.Display.__init__(self, *args, **keys)
File "/usr/local/lib/python3.10/site-packages/Xlib/protocol/display.py", line 84, in __init__
name, protocol, host, displayno, screenno = connect.get_display(display)
File "/usr/local/lib/python3.10/site-packages/Xlib/support/connect.py", line 73, in get_display
return mod.get_display(display)
File "/usr/local/lib/python3.10/site-packages/Xlib/support/unix_connect.py", line 59, in get_display
raise error.DisplayNameError(display)
Xlib.error.DisplayNameError: Bad display name "" |
That should be resolved by https://stackoverflow.com/a/44434831 |
qstokkink
changed the title
READY: Added Docker build action
WIP: Added Docker build action
Aug 26, 2024
Another issue: this build does not package the |
xoriole
force-pushed
the
add_docker_build
branch
from
August 28, 2024 13:10
4ad7eee
to
e0d44ff
Compare
xoriole
reviewed
Aug 28, 2024
qstokkink
changed the title
WIP: Added Docker build action
READY: Added Docker build action
Aug 28, 2024
xoriole
approved these changes
Aug 28, 2024
qstokkink
force-pushed
the
add_docker_build
branch
3 times, most recently
from
August 29, 2024 12:40
74e44dc
to
9ef96c2
Compare
qstokkink
force-pushed
the
add_docker_build
branch
from
September 2, 2024 08:02
9ef96c2
to
134fa64
Compare
egbertbouman
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8105
This PR:
The latest build is available here: https://github.com/qstokkink/tribler/actions/runs/10506075807