Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Versioning TypeScript types #8100

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fixed Versioning TypeScript types #8100

merged 1 commit into from
Aug 20, 2024

Conversation

qstokkink
Copy link
Contributor

Fixes #8098

This PR:

  • Fixes the type violations in Versions.tsx and tribler.service.ts.

@qstokkink
Copy link
Contributor Author

Validation on Windows 3.9, IPv4 got stuck - rerunning.

For some reason the Python 3.9 validation on Windows just gets stuck all the time 🤔 Perhaps we should just disable it.

@qstokkink qstokkink changed the title WIP: Fixed Versioning TypeScript types READY: Fixed Versioning TypeScript types Aug 20, 2024
@qstokkink qstokkink marked this pull request as ready for review August 20, 2024 13:06
@qstokkink qstokkink changed the title READY: Fixed Versioning TypeScript types Fixed Versioning TypeScript types Aug 20, 2024
@qstokkink qstokkink merged commit 0b492b4 into Tribler:main Aug 20, 2024
6 checks passed
@qstokkink qstokkink deleted the fix_npm_version_types branch August 20, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error building npm
2 participants
@qstokkink @egbertbouman